labath added a comment.
The thing to be aware of with this testing strategy is that you will probably
be the only person who will be able to run these tests and verify dwz
functionality. If you don't setup a buildbot testing this then other developers
will never even know if they have broken any dwz functionality in the future.
While end-to-end tests are great and we need them, I think it would be
worthwhile to think about other testing strategies. These can range from
checking in a couple of siple dwz files and making sure we can extract
information from them (see unittests/SymbolFile/PDB for code that does
something similar) to reimplementing/upstreaming the utilities necessary to
build dwz files ourselves (I am not sure what the `dwz` tool does, but the
`eu-strip` and `sepdebugcrcfix` tools sound like they would be fairly easy to
implement on top of existing llvm libraries).
The other thing that worries me is that your comments seem to indicate that not
all dwz tests pass after this. Could you elaborate on the "Many ERRORs are
correct" part and how you plan to rectify that?
The third thing I want to say is not really related to your patchset, but your
comments seem to indicate that not all regular dwarf tests were passing for you
to begin with. Is that true? Would you be willing to help me (probably in a
separate thread) to identify the tests that are failing and why? I'd like to
move us towards a state where the result of the tests does not depend on the
system you're running on and people don't have to resort to differential
comparisons.
================
Comment at: packages/Python/lldbsuite/test/test_categories.py:43
+if (os.access("/usr/lib/rpm/sepdebugcrcfix", os.X_OK)
+ and distutils.spawn.find_executable("eu-strip") is not None
----------------
The way we do these sorts of things is that we explicitly add the category to
the list of skipped categories (take a look at `checkLibcxxSupport` in
dotest.py).
https://reviews.llvm.org/D40475
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
