[Lldb-commits] [PATCH] D39487: Add float/vector registers for ppc64le

2017-11-03 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL317329: Add float/vector registers for ppc64le (authored by labath). Changed prior to commit: https://reviews.llvm.org/D39487?vs=121478&id=121486#toc Repository: rL LLVM https://reviews.llvm.org/D39

[Lldb-commits] [PATCH] D39487: Add float/vector registers for ppc64le

2017-11-03 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Thank you, I'll commit that right away. https://reviews.llvm.org/D39487 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D39487: Add float/vector registers for ppc64le

2017-11-03 Thread Alexandre Yukio Yamashita via Phabricator via lldb-commits
alexandreyy added a comment. Thanks @labath. I adjusted the VSX and VMX methods. https://reviews.llvm.org/D39487 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D39487: Add float/vector registers for ppc64le

2017-11-03 Thread Alexandre Yukio Yamashita via Phabricator via lldb-commits
alexandreyy updated this revision to Diff 121478. alexandreyy added a comment. Simplified vector register methods https://reviews.llvm.org/D39487 Files: packages/Python/lldbsuite/test/make/Makefile.rules source/Core/ArchSpec.cpp source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc6

[Lldb-commits] [PATCH] D39487: Add float/vector registers for ppc64le

2017-11-02 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.cpp:534 +Status NativeRegisterContextLinux_ppc64le::ReadVMX() { + void *buf = GetVMXBuffer(); + if (!buf) Isn't this somewhat over-engineered? I mean, Ge

[Lldb-commits] [PATCH] D39487: Add float/vector registers for ppc64le

2017-11-01 Thread Alexandre Yukio Yamashita via Phabricator via lldb-commits
alexandreyy added a comment. @clayborg Thanks for the review. @eugene , @labath Could you, please, commit this patch? I don't have the permission for it. https://reviews.llvm.org/D39487 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D39487: Add float/vector registers for ppc64le

2017-11-01 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks fine. https://reviews.llvm.org/D39487 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [PATCH] D39487: Add float/vector registers for ppc64le

2017-11-01 Thread Alexandre Yukio Yamashita via Phabricator via lldb-commits
alexandreyy created this revision. Herald added subscribers: JDevlieghere, kbarton, nemanjai. Add read and write functions for VSX, VMX and float registers and fix watchpoint size https://reviews.llvm.org/D39487 Files: packages/Python/lldbsuite/test/make/Makefile.rules source/Core/ArchSpec