scott.smith marked an inline comment as done.
scott.smith added a comment.
In https://reviews.llvm.org/D32820#759141, @emaste wrote:
> > Without tcmalloc, on Ubuntu 14.04, 40 core VM: 13%
> > With tcmalloc, on Ubuntu 14.04, 40 core VM: 24% (built using cmake ...
> > -DCMAKE_EXE_LINKER_FLAGS=-lt
emaste added a comment.
> Without tcmalloc, on Ubuntu 14.04, 40 core VM: 13%
> With tcmalloc, on Ubuntu 14.04, 40 core VM: 24% (built using cmake ...
> -DCMAKE_EXE_LINKER_FLAGS=-ltcmalloc_minimal, which amazingly only works when
> building with clang, not gcc...)
Do you have a brief set of ste
scott.smith marked an inline comment as done.
scott.smith added a comment.
In https://reviews.llvm.org/D32820#747309, @clayborg wrote:
> What are the measured improvements here? We can't slow things down on any
> platforms. I know MacOS didn't respond well to making demangling run in
> parallel
clayborg added a comment.
What are the measured improvements here? We can't slow things down on any
platforms. I know MacOS didn't respond well to making demangling run in
parallel. I want to see some numbers here. And please don't quote numbers with
tcmalloc or any special allocator unless you
scott.smith added inline comments.
Comment at: source/Symbol/Symtab.cpp:257
-// The "const char *" in "class_contexts" must come from a
-// ConstString::GetCString()
-std::set class_contexts;
-UniqueCStringMap mangled_name_to_index;
-std::vector symbol_conte
labath added inline comments.
Comment at: source/Symbol/Symtab.cpp:257
-// The "const char *" in "class_contexts" must come from a
-// ConstString::GetCString()
-std::set class_contexts;
-UniqueCStringMap mangled_name_to_index;
-std::vector symbol_contexts(n
scott.smith added a comment.
This commit uses TaskMapOverInt from change https://reviews.llvm.org/D32757,
which hasn't landed yet.
Repository:
rL LLVM
https://reviews.llvm.org/D32820
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http
scott.smith created this revision.
Use TaskMapOverInt to demangle the symbols in parallel. Defer categorization
of C++ symbols until later, when it can be determined what contexts are
definitely classes, and what might not be.
Repository:
rL LLVM
https://reviews.llvm.org/D32820
Files:
i
