scott.smith added inline comments.
================
Comment at: source/Symbol/Symtab.cpp:257
- // The "const char *" in "class_contexts" must come from a
- // ConstString::GetCString()
- std::set<const char *> class_contexts;
- UniqueCStringMap<uint32_t> mangled_name_to_index;
- std::vector<const char *> symbol_contexts(num_symbols, nullptr);
-
- for (entry.value = 0; entry.value < num_symbols; ++entry.value) {
- const Symbol *symbol = &m_symbols[entry.value];
+ auto symbol_fn = [&states, this](size_t value) {
+ const Symbol *symbol = &m_symbols[value];
----------------
labath wrote:
> The function looks big enough to deserve a name. (== Please move the lambda
> out of line)
ok but now's your chance to review it as a diff rather than a sea of red and
green....
Repository:
rL LLVM
https://reviews.llvm.org/D32820
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
