This revision was automatically updated to reflect the committed changes.
Closed by commit rL299200: [LLDB][MIPS] Core Dump Support. (authored by
nitesh.jain).
Changed prior to commit:
https://reviews.llvm.org/D30457?vs=92768&id=93616#toc
Repository:
rL LLVM
https://reviews.llvm.org/D30457
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Thank you.
https://reviews.llvm.org/D30457
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
nitesh.jain added a comment.
Added test case for MIPS in https://reviews.llvm.org/D31280
https://reviews.llvm.org/D30457
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
nitesh.jain updated this revision to Diff 92768.
nitesh.jain added a comment.
In case of MIPS, The ELFLinuxPrPsInfo.pr_uid and ELFLinuxPrPsInfo.pr_gid is
always 32 bit irrespective of platforms
https://reviews.llvm.org/D30457
Files:
source/Core/ArchSpec.cpp
source/Plugins/Process/FreeBSD/R
nitesh.jain added a comment.
In https://reviews.llvm.org/D30457#694306, @labath wrote:
> Thank you for updating that. Let me know what the make_core investigation
> uncovers.
In case of MIPS, the core file doesn't contain Arch and OS information. Hence
we shared information from executable.
nitesh.jain updated this revision to Diff 91881.
nitesh.jain added a comment.
Update Diff as per suggestion
https://reviews.llvm.org/D30457
Files:
source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_mips64.h
source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp
labath added a comment.
Thank you for updating that. Let me know what the make_core investigation
uncovers.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:164
+ case llvm::Triple::mips64el:
+const RegisterContextLinux_mips64 *reg_context_m
nitesh.jain marked an inline comment as done.
nitesh.jain added a comment.
The .note.ABI-tag is missing in the ELF file, generated by
test/testcases/functionalities/postmortem/elf-core/make-core.sh. Need to look
into it.
-Thanks
https://reviews.llvm.org/D30457
___
nitesh.jain marked an inline comment as done.
nitesh.jain added inline comments.
Comment at: source/Plugins/Process/Utility/RegisterInfoInterface.h:32
+ virtual const lldb_private::RegisterSet *
+ GetRegisterSet(size_t set) const {return nullptr;}
labath wrot
nitesh.jain updated this revision to Diff 90328.
nitesh.jain added a comment.
Update diff as per suggestion.
https://reviews.llvm.org/D30457
Files:
source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_mips64.h
source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp
eugene added inline comments.
Comment at: source/Plugins/Process/Utility/RegisterContextFreeBSD_mips64.cpp:31
+// Number of register sets provided by this context.
+enum { k_num_register_sets = 1 };
+
Here and below why not use
constexpr size_t k_num_register_s
clayborg resigned from this revision.
clayborg added a comment.
I will let Pavel do this review as it is in his area of expertise.
https://reviews.llvm.org/D30457
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
labath added a comment.
Have you tried running the
`test/testcases/functionalities/postmortem/elf-core/make-core.sh` script? Does
it generate a reasonably-sized core file (potentially you may need to increase
the stack limit slightly). It would be great to have a mips core file test for
this.
nitesh.jain created this revision.
This patch add support for core file. This patch includes
- Separation of register context which was earlier share between Linux and
FreeBSD.
- Add support to analyse Linux core file for all three ABI (N32, N64 and O32)
https://reviews.llvm.org/D30457
F
14 matches
Mail list logo
