nitesh.jain marked an inline comment as done.
nitesh.jain added inline comments.
================
Comment at: source/Plugins/Process/Utility/RegisterInfoInterface.h:32
+ virtual const lldb_private::RegisterSet *
+ GetRegisterSet(size_t set) const {return nullptr;}
----------------
labath wrote:
> While I don't see anything obviously wrong about adding this interface, I am
> wondering why the other subclasses have not needed this.
>
> I'd defer to @clayborg judgement on the appropriateness of the interface.
> What I don't like however, is that the default implementation will blatantly
> lie about the number of register sets for the non-mips case.
>
> What I can suggest is to avoid putting these functions in the generic class
> -- you seem to be calling them from mips code only, so I don't see any
> immediate need to have them here. (e.g. have GetRegisterInfoInterface() cast
> to the appropriate type).
In case of MIPS, the register set is different for FreeBSD and Linux. In other
platform, the register set may be same.
https://reviews.llvm.org/D30457
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
