This revision was automatically updated to reflect the committed changes.
Closed by commit rL287188: Convert AutoComplete related code to StringRef.
(authored by zturner).
Changed prior to commit:
https://reviews.llvm.org/D26721?vs=78110&id=78299#toc
Repository:
rL LLVM
https://reviews.llvm
tfiala accepted this revision.
tfiala added a comment.
LGTM! All tests passed on macOS 10.12.2 public beta with Xcode 8.1.
https://reviews.llvm.org/D26721
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
Great. Back soon...
On Wed, Nov 16, 2016 at 3:50 PM, Zachary Turner wrote:
> No you can go ahead. The new changes I found are not specific to Mac, I
> should find problems if there's any with the additional changes.
>
> On Wed, Nov 16, 2016 at 3:42 PM Todd Fiala wrote:
>
>> Okay cool. I'm bu
No you can go ahead. The new changes I found are not specific to Mac, I
should find problems if there's any with the additional changes.
On Wed, Nov 16, 2016 at 3:42 PM Todd Fiala wrote:
> Okay cool. I'm building against this now. Should I hold off testing?
>
> On Wed, Nov 16, 2016 at 3:41 PM
Okay cool. I'm building against this now. Should I hold off testing?
On Wed, Nov 16, 2016 at 3:41 PM, Zachary Turner wrote:
> It's no problem, I actually found a few functions I forgot to convert, so
> I'm making some additional changes. Nothing that requires additional
> testing, but at the
It's no problem, I actually found a few functions I forgot to convert, so
I'm making some additional changes. Nothing that requires additional
testing, but at the very least I won't be able to get this in until
tomorrow at the earliest, so it's no biggie.
On Wed, Nov 16, 2016 at 3:17 PM Todd Fial
Hey Zachary,
I had to run home unexpectedly. The build worked but I left before the test
results came out.
If you ran it on Linux and the Linux tests passed, we can address issues
that show up on the macOS side.
I will also try it at home on macOS, but I don't think you need to hold up
with the
Hey Todd, Did you run the tests earlier? If so what was the result? No
worries if you didn't run them yet, but it sounded like you were already
kicking it off at 11:30. Just want to make sure you didn't finish and
forget to update with the result :)
On Wed, Nov 16, 2016 at 12:38 PM Todd Fiala
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM!
The big thing to be aware of about Twines is that they are designed so that
when you construct one the underlying string storage can vanish after the Twine
goes out of scope. Here it look
Yep - I followed that. I'm just doing the "build + test" verification on
macOS.
On Wed, Nov 16, 2016 at 11:41 AM, Zachary Turner wrote:
> BTW, I would still like to get Chris to take a look at my usage of
> llvm::Twine. Even if it works, I'm not sure if I used it correctly.
>
> On Wed, Nov 16
BTW, I would still like to get Chris to take a look at my usage of
llvm::Twine. Even if it works, I'm not sure if I used it correctly.
On Wed, Nov 16, 2016 at 11:36 AM Zachary Turner wrote:
> Either way is fine, I think you might have hit a merge conflict if you
> stacked them, but if you've al
Either way is fine, I think you might have hit a merge conflict if you
stacked them, but if you've already worked through it, then no big deal.
On Wed, Nov 16, 2016 at 11:30 AM Todd Fiala wrote:
> tfiala added a comment.
>
> I'm going to test this one now, stacked on top of the final macOS-worki
tfiala added a comment.
I'm going to test this one now, stacked on top of the final macOS-working
version of https://reviews.llvm.org/D26698. Tell me now if you want it tested
independently of https://reviews.llvm.org/D26698.
https://reviews.llvm.org/D26721
tfiala added a comment.
I can give this one a run though on macOS in the morning.
https://reviews.llvm.org/D26721
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner created this revision.
zturner added reviewers: beanz, tfiala.
zturner added a subscriber: lldb-commits.
As per the title. beanz@, could you specifically look over my usage of
`llvm::Twine`? This is the first time I've used this class, and I'm not sure
if I'm using it correctly / effic
15 matches
Mail list logo
