beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land.
LGTM! The big thing to be aware of about Twines is that they are designed so that when you construct one the underlying string storage can vanish after the Twine goes out of scope. Here it looks like you're really just allowing some functions to take Twines, it doesn't look like you're constructing any, so it seems all good to me. https://reviews.llvm.org/D26721 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
