labath closed this revision.
labath added a comment.
Submitted in r276406.
https://reviews.llvm.org/D22628
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Ok, nevermind then. Looks good.
https://reviews.llvm.org/D22628
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/c
dvlahovski added a comment.
So, alignas doesn't work with typedef
We can use a #define but that's kind of ugly
https://reviews.llvm.org/D22628
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/l
labath added a comment.
Looks good, just please fix the small stylistic issue.
Comment at: source/Plugins/Process/elf-core/ThreadElfCore.h:24
@@ -23,3 +23,3 @@
{
-int64_t tv_sec;
-int32_t tv_usec;
+alignas(8) uint64_t tv_sec;
+alignas(8) uint64_t tv_usec;
--
dvlahovski created this revision.
dvlahovski added a reviewer: labath.
dvlahovski added a subscriber: lldb-commits.
The binary layout of prstatus and prpsinfo was wrong.
Some of the member variables where not aligned properly
and others where with a wrong type (e.g. the time related
stuff in prsta
dvlahovski updated this revision to Diff 64902.
dvlahovski added a comment.
Forgot to add alignas to two members of prstatus
https://reviews.llvm.org/D22628
Files:
source/Plugins/Process/elf-core/ThreadElfCore.cpp
source/Plugins/Process/elf-core/ThreadElfCore.h
Index: source/Plugins/Proces
