This revision was automatically updated to reflect the committed changes.
Closed by commit rL270831: Avoid using stdio in TestVirtual (authored by
labath).
Changed prior to commit:
http://reviews.llvm.org/D20567?vs=58418&id=58579#toc
Repository:
rL LLVM
http://reviews.llvm.org/D20567
Files
labath updated this revision to Diff 58418.
labath added a comment.
New version, which does not rely on pretty-printers.
http://reviews.llvm.org/D20567
Files:
packages/Python/lldbsuite/test/lang/cpp/virtual/TestVirtual.py
packages/Python/lldbsuite/test/lang/cpp/virtual/main.cpp
Index: pack
clayborg added a comment.
I would just make a large buffer and use snprintf:
char buffer[4096];
char *p = buffer;
char *end = p + sizeof(buffer);
p += snprintf(p, end - p, "a_as_A->a() = '%s'\n", a_as_A->a());
p += snprintf(p, end - p, "a_as_A->b() = '%s'\n", a_as_A->b());
http://revi
labath added inline comments.
Comment at: packages/Python/lldbsuite/test/lang/cpp/virtual/TestVirtual.py:64
@@ +63,3 @@
+self.assertTrue(golden.IsValid(), "Encountered an error reading the
process's golden variable")
+golden_str = str(golden)
+self.assertT
clayborg requested changes to this revision.
This revision now requires changes to proceed.
Comment at: packages/Python/lldbsuite/test/lang/cpp/virtual/TestVirtual.py:64
@@ +63,3 @@
+self.assertTrue(golden.IsValid(), "Encountered an error reading the
process's golden vari
labath created this revision.
labath added a reviewer: clayborg.
labath added subscribers: zturner, lldb-commits.
using stdio in tests does not work on windows, and it is not completely
reliable on linux.
Avoid using stdio in this test, as it is not necessary for this purpose.
http://reviews.llv
