This revision was automatically updated to reflect the committed changes.
Closed by commit rL271863: Fix function name lookup in IRExecutionEngine.cpp.
(authored by sas).
Changed prior to commit:
http://reviews.llvm.org/D20312?vs=57854&id=59685#toc
Repository:
rL LLVM
http://reviews.llvm.or
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D20312
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
sas updated this revision to Diff 57854.
sas added a comment.
No need to use `.AsCString()` on these.
http://reviews.llvm.org/D20312
Files:
source/Expression/IRExecutionUnit.cpp
Index: source/Expression/IRExecutionUnit.cpp
===
-
sas added a comment.
Ah yes, good idea not to use `AsCString()` here.
I think changing the `!=` to `==` is the right thing to do here because the bug
was introduced in r263995:
@@ -122,7 +125,7 @@ IRExecutionUnit::DisassembleFunction (Stream &stream,
for (JittedFunction &function :
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
See inlined comments.
Comment at: source/Expression/IRExecutionUnit.cpp:128
@@ -127,3 +127,3 @@
{
-if (function.m_name.AsCString() != m_name.AsCStri
sas created this revision.
sas added a reviewer: spyffe.
sas added a subscriber: lldb-commits.
Without this commit, when `log enable lldb expr` is enabled, the
disassembly of JIT'ed code is never displayed.
http://reviews.llvm.org/D20312
Files:
source/Expression/IRExecutionUnit.cpp
Index: sou
