Re: [Lldb-commits] [PATCH] D19685: Fix NetBSD build with CMake 3.5.2

2016-05-01 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. Thanks, since it has been accepted. I will commit it and move to LLDBStandalone. Repository: rL LLVM http://reviews.llvm.org/D19685 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-b

Re: [Lldb-commits] [PATCH] D19685: Fix NetBSD build with CMake 3.5.2

2016-05-01 Thread Pavel Labath via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I like this solution. Repository: rL LLVM http://reviews.llvm.org/D19685 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://list

Re: [Lldb-commits] [PATCH] D19685: Fix NetBSD build with CMake 3.5.2

2016-04-30 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. In http://reviews.llvm.org/D19685#417919, @zturner wrote: > Ahh ok. Well setting it to 2.8.12 is still fine, if that fixes the problem > with no other changes then that seems like the best fix. No other changes are needed. Repository: rL LLVM http://reviews.l

Re: [Lldb-commits] [PATCH] D19685: Fix NetBSD build with CMake 3.5.2

2016-04-30 Thread Zachary Turner via lldb-commits
Ahh ok. Well setting it to 2.8.12 is still fine, if that fixes the problem with no other changes then that seems like the best fix. On Sat, Apr 30, 2016 at 5:23 PM Kamil Rytarowski wrote: > krytarowski added a comment. > > In http://reviews.llvm.org/D19685#417911, @zturner wrote: > > > Can't yo

Re: [Lldb-commits] [PATCH] D19685: Fix NetBSD build with CMake 3.5.2

2016-04-30 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. In http://reviews.llvm.org/D19685#417911, @zturner wrote: > Can't you just remove that line and let it inherit the minimum version from > LLVM? It doesn't work. CMake Warning (dev) in CMakeLists.txt: No cmake_minimum_required command is present. A line of c

Re: [Lldb-commits] [PATCH] D19685: Fix NetBSD build with CMake 3.5.2

2016-04-30 Thread Zachary Turner via lldb-commits
Can't you just remove that line and let it inherit the minimum version from LLVM? On Sat, Apr 30, 2016 at 4:58 PM Kamil Rytarowski wrote: > krytarowski updated this revision to Diff 55729. > krytarowski added a comment. > > Set minimal required CMake to 2.8.12.2 - fixes build on NetBSD with CMak

Re: [Lldb-commits] [PATCH] D19685: Fix NetBSD build with CMake 3.5.2

2016-04-30 Thread Kamil Rytarowski via lldb-commits
krytarowski updated this revision to Diff 55729. krytarowski added a comment. Set minimal required CMake to 2.8.12.2 - fixes build on NetBSD with CMake 3.5.2 Repository: rL LLVM http://reviews.llvm.org/D19685 Files: CMakeLists.txt cmake/modules/LLDBStandalone.cmake Index: cmake/modules/

Re: [Lldb-commits] [PATCH] D19685: Fix NetBSD build with CMake 3.5.2

2016-04-30 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. In http://reviews.llvm.org/D19685#417896, @zturner wrote: > I don't think we should be adding more CMake hacks in lldb when llvm is > supposed to handle this. Why don't the existing lines work? I don't know. Perhaps because LLVM and Clang requires newer cmake than

Re: [Lldb-commits] [PATCH] D19685: Fix NetBSD build with CMake 3.5.2

2016-04-30 Thread Zachary Turner via lldb-commits
I don't think we should be adding more CMake hacks in lldb when llvm is supposed to handle this. Why don't the existing lines work? On Sat, Apr 30, 2016 at 4:24 PM Kamil Rytarowski wrote: > krytarowski added a comment. > > I had this working with 2.8: > > --- source/Plugins/SymbolFile/PDB/CMake

Re: [Lldb-commits] [PATCH] D19685: Fix NetBSD build with CMake 3.5.2

2016-04-30 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. I had this working with 2.8: --- source/Plugins/SymbolFile/PDB/CMakeLists.txt.orig 2016-04-27 00:55:50.0 + +++ source/Plugins/SymbolFile/PDB/CMakeLists.txt @@ -1,7 +1,11 @@ -set(LLVM_PRIVATE_LINK_COMPONENTS -DebugInfoPDB) +#set(LLVM_PRIV

Re: [Lldb-commits] [PATCH] D19685: Fix NetBSD build with CMake 3.5.2

2016-04-29 Thread Greg Clayton via lldb-commits
clayborg resigned from this revision. clayborg removed a reviewer: clayborg. clayborg added a comment. I will the unix / cmake experts make the decision here. Repository: rL LLVM http://reviews.llvm.org/D19685 ___ lldb-commits mailing list lldb-c

Re: [Lldb-commits] [PATCH] D19685: Fix NetBSD build with CMake 3.5.2

2016-04-29 Thread Zachary Turner via lldb-commits
zturner added a subscriber: zturner. zturner added a comment. Agree, the build should work with 2.8.12, but feel free to take advantage of newer cmake features if they're present Repository: rL LLVM http://reviews.llvm.org/D19685 ___ lldb-commits

Re: [Lldb-commits] [PATCH] D19685: Fix NetBSD build with CMake 3.5.2

2016-04-29 Thread Pavel Labath via lldb-commits
labath added a reviewer: zturner. labath added a comment. cmake 2.8 is still widely used (Ubuntu 14.04 LTS for one, but there are people around using even longer lived versions of RedHat). I don't think we should bump the version over a tiny detail like this. I'm pretty sure there is a way to r