This revision was automatically updated to reflect the committed changes.
Closed by commit rL264030: [LLDB]{MIPS] Fix TestPlatformProcessConnect.py
(authored by mohit.bhakkad).
Changed prior to commit:
http://reviews.llvm.org/D18082?vs=50569&id=51260#toc
Repository:
rL LLVM
http://reviews.l
nitesh.jain added a comment.
Hi Tamas Berghammer,
Is it ok to commit?
Repository:
rL LLVM
http://reviews.llvm.org/D18082
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath accepted this revision.
labath added a comment.
Looks great. Thank you.
Repository:
rL LLVM
http://reviews.llvm.org/D18082
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
nitesh.jain updated this revision to Diff 50569.
nitesh.jain added a comment.
Herald added subscribers: srhines, danalbert, tberghammer.
Updated diff as per suggestion.
Repository:
rL LLVM
http://reviews.llvm.org/D18082
Files:
source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D18082
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
labath added a comment.
If I understand correctly, you have simply copied the implementation from
PlatformRemoteAndroidGDBServer. Could you also remove it from that class, since
it's going to inherit the implementation anyway?
Apart from that, it looks good to me, but let's give a chance for @c
nitesh.jain created this revision.
nitesh.jain added reviewers: clayborg, tberghammer, labath.
nitesh.jain added subscribers: jaydeep, bhushan, sagar, mohit.bhakkad,
lldb-commits.
nitesh.jain set the repository for this revision to rL LLVM.
The patch http://reviews.llvm.org/D14952 which modifies
