This revision was automatically updated to reflect the committed changes.
tberghammer marked 2 inline comments as done.
Closed by commit rL262015: Add a set of new plugins to handle Java debugging
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D17616?vs=49089&id=491
tberghammer marked 2 inline comments as done.
Comment at: source/Plugins/Language/Java/JavaLanguage.cpp:81
@@ +80,3 @@
+HardcodedFormatters::HardcodedSummaryFinder
+JavaLanguage::GetHardcodedSummaries()
+{
granata.enrico wrote:
> Is there any reason to use hardcod
granata.enrico added a subscriber: granata.enrico.
Comment at: source/Plugins/Language/Java/JavaLanguage.cpp:81
@@ +80,3 @@
+HardcodedFormatters::HardcodedSummaryFinder
+JavaLanguage::GetHardcodedSummaries()
+{
Is there any reason to use hardcoded summaries here?
ovyalov accepted this revision.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserJava.cpp:35
@@ +34,3 @@
+lldb::TypeSP
+DWARFASTParserJava::ParseTypeFromDWARF(const lldb_private::SymbolContext &sc,
const DWARFDIE &die,
+ lldb_private
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D17616
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
tberghammer created this revision.
tberghammer added reviewers: ovyalov, clayborg.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
Add a set of new plugins to handle Java debugging
The purpose of these plugins is to make LLDB capable of debugging ja
