Yes, exactly.
Jim
> On Feb 24, 2016, at 4:11 AM, Tamas Berghammer wrote:
>
> tberghammer added a comment.
>
> In http://reviews.llvm.org/D17535#360519, @bhushan wrote:
>
>> In MIPS, we can not put a breakpoint in middle of an atomic sequence.
>> If we do so (and that breakpoint is hit) then c
jingham added a subscriber: jingham.
jingham added a comment.
Yes, exactly.
Jim
Repository:
rL LLVM
http://reviews.llvm.org/D17535
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
tberghammer added a comment.
In http://reviews.llvm.org/D17535#360519, @bhushan wrote:
> In MIPS, we can not put a breakpoint in middle of an atomic sequence.
> If we do so (and that breakpoint is hit) then continuing from breakpoint
> address will cause "SC" to fail due to a breakpoint excepti
bhushan added a comment.
In MIPS, we can not put a breakpoint in middle of an atomic sequence.
If we do so (and that breakpoint is hit) then continuing from breakpoint
address will cause "SC" to fail due to a breakpoint exception.
SC fails when there’s been any exception serviced since the LL. Th
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
IIUC, what you are doing here is when lldb-server gets a "step instruction"
request that would step into one of these atomic regions, it sets a bunch of
breakpoints on it's end (no
tberghammer added a comment.
I am not sure I agree with the following starting point of the CL (I know about
the similar functionality in GDB) and even if we agree in it I think you are
handling a very small fraction of the problems.
> LLDB should treat all instructions in the atomic sequence a
clayborg resigned from this revision.
clayborg edited reviewers, added: jingham; removed: clayborg.
clayborg added a comment.
Looks good to me, but I think Jim Ingham should have a look in case he has
anything to add since Jim is the master or stepping.
Repository:
rL LLVM
http://reviews.llv
labath added a subscriber: labath.
labath added a comment.
I'll leave the final review to Tamas, just a couple of comments here.
Comment at:
packages/Python/lldbsuite/test/functionalities/single_step_atomic_sequence/TestStepInAtomicSequence.py:70
@@ +69,3 @@
+inst_o
bhushan created this revision.
bhushan added reviewers: clayborg, tberghammer.
bhushan added subscribers: lldb-commits, jaydeep, nitesh.jain, mohit.bhakkad,
sagar.
bhushan set the repository for this revision to rL LLVM.
This patch handles atomic sequences during single step.
LLDB should treat a
