Re: [Lldb-commits] [PATCH] D15530: [test] Add ability to expect timeouts

2015-12-16 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL255763: [test] Add ability to expect timeouts (authored by labath). Changed prior to commit: http://reviews.llvm.org/D15530?vs=42858&id=42985#toc Repository: rL LLVM http://reviews.llvm.org/D15530

Re: [Lldb-commits] [PATCH] D15530: [test] Add ability to expect timeouts

2015-12-16 Thread Pavel Labath via lldb-commits
No worries. I wanted to rename that function anyway, but then I forgot, so it's good that you have reminded me. :) On 15 December 2015 at 22:18, Todd Fiala wrote: > tfiala added a comment. > > Hey Pavel, > > Change r255676 changed a few things that will require this patch to get > updated. I th

Re: [Lldb-commits] [PATCH] D15530: [test] Add ability to expect timeouts

2015-12-16 Thread Pavel Labath via lldb-commits
labath added a subscriber: labath. labath added a comment. No worries. I wanted to rename that function anyway, but then I forgot, so it's good that you have reminded me. :) http://reviews.llvm.org/D15530 ___ lldb-commits mailing list lldb-commits@l

Re: [Lldb-commits] [PATCH] D15530: [test] Add ability to expect timeouts

2015-12-15 Thread Todd Fiala via lldb-commits
tfiala added a comment. Hey Pavel, Change r255676 changed a few things that will require this patch to get updated. I think the main code change will be that ResultsFormatter._make_rerun_eligibility_key(self) has been renamed to ResultsFormatter._make_key(self). I folded the BasicResultsForm

Re: [Lldb-commits] [PATCH] D15530: [test] Add ability to expect timeouts

2015-12-15 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. Looks good! http://reviews.llvm.org/D15530 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [PATCH] D15530: [test] Add ability to expect timeouts

2015-12-15 Thread Pavel Labath via lldb-commits
labath created this revision. labath added a reviewer: tfiala. labath added a subscriber: lldb-commits. This adds ability to mark test that do not complete due to hangs, crashes, etc., as "expected", to avoid flagging the build red for a known problem. Functionally, this extends the scope of the