krytarowski updated this revision to Diff 42800.
krytarowski added a comment.
Improve abc order of source files
Repository:
rL LLVM
http://reviews.llvm.org/D15482
Files:
source/Plugins/Process/Utility/CMakeLists.txt
source/Plugins/Process/Utility/NetBSDSignals.cpp
source/Plugins/Proces
krytarowski added inline comments.
Comment at: source/Target/UnixSignals.cpp:66
@@ -64,4 +65,3 @@
case llvm::Triple::FreeBSD:
case llvm::Triple::OpenBSD:
return std::make_shared();
emaste wrote:
> Not part of your change, but just sp
krytarowski added a comment.
Thank you. After fixing the order I'm going to land this diff.
Comment at: source/Plugins/Process/Utility/CMakeLists.txt:6
@@ -5,2 +5,3 @@
FreeBSDSignals.cpp
+ NetBSDSignals.cpp
GDBRemoteSignals.cpp
emaste wrote:
> Should keep
emaste added inline comments.
Comment at: source/Plugins/Process/Utility/CMakeLists.txt:6
@@ -5,2 +5,3 @@
FreeBSDSignals.cpp
+ NetBSDSignals.cpp
GDBRemoteSignals.cpp
Should keep these in alpha order
Comment at: source/Target/UnixSignals.cp
joerg accepted this revision.
joerg added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D15482
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
krytarowski created this revision.
krytarowski added reviewers: joerg, emaste.
krytarowski added a subscriber: lldb-commits.
krytarowski set the repository for this revision to rL LLVM.
Signals 1-32 are matching the default UNIX platform.
There are platform specific ones above 32.
From the `/usr
