emaste added inline comments.

================
Comment at: source/Plugins/Process/Utility/CMakeLists.txt:6
@@ -5,2 +5,3 @@
   FreeBSDSignals.cpp
+  NetBSDSignals.cpp
   GDBRemoteSignals.cpp
----------------
Should keep these in alpha order

================
Comment at: source/Target/UnixSignals.cpp:66
@@ -64,4 +65,3 @@
         case llvm::Triple::FreeBSD:
         case llvm::Triple::OpenBSD:
             return std::make_shared<FreeBSDSignals>();
----------------
Not part of your change, but just spotted it during this review; The default 
case should probably be used for OpenBSD. We can change it later.


Repository:
  rL LLVM

http://reviews.llvm.org/D15482



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to