This revision was automatically updated to reflect the committed changes.
Closed by commit rL254715: Improve the functionality of JSONNumber (authored by
tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D15187?vs=41743&id=41868#toc
Repository:
rL LLVM
http://reviews.llvm.org/D
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Ok, thanks for the explanation. You might add a comment saying something like
you just said above the template stuff so people can see why it is needed.
http://reviews.llvm.org/D15187
tberghammer added inline comments.
Comment at: include/lldb/Utility/JSON.h:102-104
@@ +101,5 @@
+
+template {} &&
+ std::is_unsigned{}>::type* =
nullptr>
+explicit JSONNumber (T u) :
clayborg wrote:
> What
IIU my C++ correctly, this code covers neither int64_t nor double; it covers
the unsigned variety of int64 - as well as any other unsigned integer type.
The main advantage (other than not relying on implicit promotions) would be
that if someone writes their new integral data type (BigNum), and m
granata.enrico added a subscriber: granata.enrico.
granata.enrico added a comment.
IIU my C++ correctly, this code covers neither int64_t nor double; it covers
the unsigned variety of int64 - as well as any other unsigned integer type.
The main advantage (other than not relying on implicit promo
clayborg added a comment.
Everything looks good, just wondering why we need the template code? See
inlined comments.
Comment at: include/lldb/Utility/JSON.h:102-104
@@ +101,5 @@
+
+template {} &&
+ std::is_unsigned{}>::type* =
n
tberghammer created this revision.
tberghammer added reviewers: clayborg, granata.enrico.
tberghammer added a subscriber: lldb-commits.
Improve the functionality of JSONNumber
* Add support for representing signed integers
* Add new constructors taking any signed or unsigned integer types
http:/
