clayborg added a comment.

Everything looks good, just wondering why we need the template code? See 
inlined comments.


================
Comment at: include/lldb/Utility/JSON.h:102-104
@@ +101,5 @@
+
+        template <typename T,
+                  typename std::enable_if<std::is_integral<T>{} &&
+                                          std::is_unsigned<T>{}>::type* = 
nullptr>
+        explicit JSONNumber (T u) :
----------------
What value is the template code giving us? Why can't we omit this and just have 
a constructor with int64_t and double?


http://reviews.llvm.org/D15187



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to