This revision was automatically updated to reflect the committed changes.
Closed by commit rG5014830ede78: ObjectFile: introduce a COFF object file
plugin (authored by compnerd).
Changed prior to commit:
https://reviews.llvm.org/D149987?vs=520102&id=520207#toc
Repository:
rG LLVM Github Mono
compnerd updated this revision to Diff 520102.
compnerd marked an inline comment as done.
compnerd added a comment.
Address feedback
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149987/new/
https://reviews.llvm.org/D149987
Files:
lldb/source/Plugins/ObjectFile/CMakeLists.txt
lldb/
compnerd marked 4 inline comments as done.
compnerd added inline comments.
Comment at: lldb/source/Plugins/ObjectFile/COFF/ObjectFileCOFF.cpp:203
+.Case(".debug_pubnames", eSectionTypeDWARFDebugPubNames)
+.Case(".debug_pubtypes", eSectionTypeDWARFDebugPubT
tschuett added inline comments.
Comment at: lldb/source/Plugins/ObjectFile/COFF/ObjectFileCOFF.cpp:26
+namespace {
+bool IsCOFFObjectFile(const DataBufferSP &data) {
+ return identify_magic(toStringRef(data->GetData())) ==
Could you turn this into a static inste
aprantl added inline comments.
Comment at: lldb/source/Plugins/ObjectFile/COFF/ObjectFileCOFF.cpp:203
+.Case(".debug_pubnames", eSectionTypeDWARFDebugPubNames)
+.Case(".debug_pubtypes", eSectionTypeDWARFDebugPubTypes)
+.Case(".debug_str", eSect
bulbazord accepted this revision.
bulbazord added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149987/new/
https://reviews.llvm.org/D149987
_
compnerd updated this revision to Diff 519984.
compnerd added a comment.
Address feedback, add test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149987/new/
https://reviews.llvm.org/D149987
Files:
lldb/source/Plugins/ObjectFile/CMakeLists.txt
compnerd added inline comments.
Comment at: lldb/source/Plugins/ObjectFile/COFF/ObjectFileCOFF.cpp:103-104
+
+ return new ObjectFileCOFF(module_sp, data_sp, data_offset, file, file_offset,
+length);
+}
bulbazord wrote:
> compnerd wrot
bulbazord added inline comments.
Comment at: lldb/source/Plugins/ObjectFile/COFF/ObjectFileCOFF.cpp:103-104
+
+ return new ObjectFileCOFF(module_sp, data_sp, data_offset, file, file_offset,
+length);
+}
compnerd wrote:
> bulbazord wro
compnerd added inline comments.
Comment at: lldb/source/Plugins/ObjectFile/COFF/ObjectFileCOFF.cpp:103-104
+
+ return new ObjectFileCOFF(module_sp, data_sp, data_offset, file, file_offset,
+length);
+}
bulbazord wrote:
> Reading the i
bulbazord added a comment.
We're definitely going to want a test for this, either a shell test or a unit
test.
Comment at: lldb/source/Plugins/ObjectFile/COFF/ObjectFileCOFF.cpp:103-104
+
+ return new ObjectFileCOFF(module_sp, data_sp, data_offset, file, file_offset,
+
aprantl added a comment.
Is there a way to compile something with clang and then load the object file
into lldb-test so we could add a shell test for it?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149987/new/
https://reviews.llvm.org/D149987
_
aprantl added a comment.
Could you build this into a yaml2obj obj2yaml plugin, so we could test this?
Alternatively, you could check in a minimal binary.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149987/new/
https://reviews.llvm.org/D149987
__
compnerd created this revision.
compnerd added reviewers: aprantl, kastiglione.
compnerd added a project: LLDB.
Herald added a subscriber: JDevlieghere.
Herald added a project: All.
compnerd requested review of this revision.
Windows uses COFF as an object file format and PE/COFF as an executable
14 matches
Mail list logo
