This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2e16e41b28b1: Add AArch64 MASK watchpoint support in
debugserver (authored by jasonmolenda).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LA
jasonmolenda updated this revision to Diff 519629.
jasonmolenda added a comment.
Update patch with Dan and Jonas' feedback.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149792/new/
https://reviews.llvm.org/D149792
Files:
lldb/test/API/functiona
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
Some small nits but LGTM
Comment at: lldb/tools/debugserver/source/MacOSX/arm64/DNBArchImplARM64.cpp:1079
+ // masked off) -- a MASK value of 31.
+ uint64_t mas
delcypher added inline comments.
Comment at:
lldb/test/API/python_api/watchpoint/watchlocation/TestTargetWatchAddress.py:132
value.GetType().GetPointeeType())
-# Watch for write to *g_char_ptr.
-error = lldb.SBError()
@jasonmolenda M
jasonmolenda created this revision.
jasonmolenda added a reviewer: JDevlieghere.
jasonmolenda added a project: LLDB.
Herald added subscribers: omjavaid, kristof.beyls.
Herald added a project: All.
jasonmolenda requested review of this revision.
Herald added a subscriber: lldb-commits.
AArch64 supp
