JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land.
Some small nits but LGTM ================ Comment at: lldb/tools/debugserver/source/MacOSX/arm64/DNBArchImplARM64.cpp:1079 + // masked off) -- a MASK value of 31. + uint64_t mask = __builtin_popcountl(wp.aligned_size - 1) << 24; + // A '0b11111111' BAS value needed for mask watchpoints plus a ---------------- I assume this can be `const`? ================ Comment at: lldb/tools/debugserver/source/MacOSX/arm64/DNBArchImplARM64.cpp:1082 + // nonzero mask value. + uint64_t not_bas_wp = 0xff << 5; + ---------------- `const` too? ================ Comment at: lldb/tools/debugserver/source/MacOSX/arm64/DNBArchImplARM64.cpp:1260-1262 + bool is_bas_watchpoint = false; + if (mask == 0) + is_bas_watchpoint = true; ---------------- ```const bool is_bas_watchpoint = (mask ==0);``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149792/new/ https://reviews.llvm.org/D149792 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
