[Lldb-commits] [PATCH] D147669: PECOFF: consume errors properly

This revision was automatically updated to reflect the committed changes. Closed by commit rGd87cd45e4d85: PECOFF: consume errors properly (authored by Saleem Abdulrasool ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D147669: PECOFF: consume errors properly

sgraenitz accepted this revision. sgraenitz added a comment. This revision is now accepted and ready to land. Great. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147669/new/ https://reviews.llvm.org/D147669 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D147669: PECOFF: consume errors properly

compnerd added a comment. @sgraenitz done :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147669/new/ https://reviews.llvm.org/D147669 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[Lldb-commits] [PATCH] D147669: PECOFF: consume errors properly

compnerd updated this revision to Diff 513614. compnerd added a comment. Address feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147669/new/ https://reviews.llvm.org/D147669 Files: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp Index: lldb/source/Plugins/ObjectFi

[Lldb-commits] [PATCH] D147669: PECOFF: consume errors properly

sgraenitz added a comment. I think it's a very good practice that objects in moved-from state will only ever get destroyed. While the move ctor itself has no preconditions and thus might be fine to call again, the implementation of `consumeError()` does inspect the object. This adds an unnecess

[Lldb-commits] [PATCH] D147669: PECOFF: consume errors properly

compnerd updated this revision to Diff 511706. compnerd retitled this revision from "PECOFF: enforce move semantics and consume errors properly" to "PECOFF: consume errors properly". compnerd edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147669/new/ h