[Lldb-commits] [PATCH] D147669: PECOFF: consume errors properly

[Saleem Abdulrasool via Phabricator via lldb-commits]

compnerd updated this revision to Diff 511706.
compnerd retitled this revision from "PECOFF: enforce move semantics and 
consume errors properly" to "PECOFF: consume errors properly".
compnerd edited the summary of this revision.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147669/new/

https://reviews.llvm.org/D147669

Files:
  lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp


Index: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
===================================================================
--- lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
+++ lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
@@ -867,6 +867,7 @@
                "ObjectFilePECOFF::AppendFromExportTable - failed to get export 
"
                "table entry name: {0}",
                llvm::fmt_consume(std::move(err)));
+      llvm::consumeError(std::move(err));
       continue;
     }
     Symbol symbol;
@@ -888,6 +889,7 @@
                  "ObjectFilePECOFF::AppendFromExportTable - failed to get "
                  "forwarder name of forwarder export '{0}': {1}",
                  sym_name, llvm::fmt_consume(std::move(err)));
+        llvm::consumeError(std::move(err));
         continue;
       }
       llvm::SmallString<256> new_name = 
{symbol.GetDisplayName().GetStringRef(),
@@ -903,6 +905,7 @@
                "ObjectFilePECOFF::AppendFromExportTable - failed to get "
                "address of export entry '{0}': {1}",
                sym_name, llvm::fmt_consume(std::move(err)));
+      llvm::consumeError(std::move(err));
       continue;
     }
     // Skip the symbol if it doesn't look valid.



Index: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
===================================================================
--- lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
+++ lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
@@ -867,6 +867,7 @@
                "ObjectFilePECOFF::AppendFromExportTable - failed to get export "
                "table entry name: {0}",
                llvm::fmt_consume(std::move(err)));
+      llvm::consumeError(std::move(err));
       continue;
     }
     Symbol symbol;
@@ -888,6 +889,7 @@
                  "ObjectFilePECOFF::AppendFromExportTable - failed to get "
                  "forwarder name of forwarder export '{0}': {1}",
                  sym_name, llvm::fmt_consume(std::move(err)));
+        llvm::consumeError(std::move(err));
         continue;
       }
       llvm::SmallString<256> new_name = {symbol.GetDisplayName().GetStringRef(),
@@ -903,6 +905,7 @@
                "ObjectFilePECOFF::AppendFromExportTable - failed to get "
                "address of export entry '{0}': {1}",
                sym_name, llvm::fmt_consume(std::move(err)));
+      llvm::consumeError(std::move(err));
       continue;
     }
     // Skip the symbol if it doesn't look valid.

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits