Re: [Lldb-commits] [PATCH] D14023: Fix uses of range / xrange for Python 3

2015-10-24 Thread Todd Fiala via lldb-commits
tfiala added inline comments. Comment at: test/lang/go/types/TestGoASTContext.py:134 @@ -131,3 +133,3 @@ self.assertEqual(5, v.GetNumChildren()) -for i in xrange(5): +for i in six.moves.xrange(5): self.assertEqual(str(i + 1), v.GetChildAtIndex

Re: [Lldb-commits] [PATCH] D14023: Fix uses of range / xrange for Python 3

2015-10-24 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. > I've been putting most of this stuff in withouty review, but I figure every > once in a while I should pass one your way as a sanity check to make sure I'm > still on the right path. That'

Re: [Lldb-commits] [PATCH] D14023: Fix uses of range / xrange for Python 3

2015-10-23 Thread Zachary Turner via lldb-commits
zturner added inline comments. Comment at: test/lang/go/types/TestGoASTContext.py:134 @@ -131,3 +133,3 @@ self.assertEqual(5, v.GetNumChildren()) -for i in xrange(5): +for i in six.moves.xrange(5): self.assertEqual(str(i + 1), v.GetChildAtInde

[Lldb-commits] [PATCH] D14023: Fix uses of range / xrange for Python 3

2015-10-23 Thread Zachary Turner via lldb-commits
zturner created this revision. zturner added a reviewer: tfiala. zturner added a subscriber: lldb-commits. Herald added subscribers: srhines, danalbert, tberghammer. Hi Todd, I've been putting most of this stuff in withouty review, but I figure every once in a while I should pass one your way as