[Lldb-commits] [PATCH] D135621: [lldb] Add an always-on log channel

JDevlieghere abandoned this revision. JDevlieghere added a comment. Seems like the consensus is that we prefer a dedicated API rather than using the existing logging infrastructure. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135621/new/ https://reviews.llvm.org/D135621

[Lldb-commits] [PATCH] D135621: [lldb] Add an always-on log channel

labath added a comment. In D135621#3875218 , @JDevlieghere wrote: > In D135621#3850248 , @clayborg > wrote: > >> I am also questioning if the these even belong in the LLDB logging stuff? >> Seems like it would

[Lldb-commits] [PATCH] D135621: [lldb] Add an always-on log channel

JDevlieghere added inline comments. Comment at: lldb/source/Utility/Diagnostics.cpp:23 +static constexpr Log::Category g_categories[] = { +{{"lldb"}, {"diagnostics log for lldb"}, DiagnosticsLog::LLDB}, +}; kastiglione wrote: > To me, it's not ideal that ther

[Lldb-commits] [PATCH] D135621: [lldb] Add an always-on log channel

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. > I expect the majority of places where we want to log to the diagnostic log > channel to be places where we already log today. This is my expectation too. Some logs are helpful for

[Lldb-commits] [PATCH] D135621: [lldb] Add an always-on log channel

JDevlieghere added a comment. In D135621#3850248 , @clayborg wrote: > I am also questioning if the these even belong in the LLDB logging stuff? > Seems like it would be just as easy to create a diagnostic message by calling > Diagnostics::Report(...). D

[Lldb-commits] [PATCH] D135621: [lldb] Add an always-on log channel

JDevlieghere updated this revision to Diff 469677. JDevlieghere added a comment. - Address code review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135621/new/ https://reviews.llvm.org/D135621 Files: lldb/include/lldb/Utility/Diagnostics.h lldb/include/lldb/Utility/Log.h

[Lldb-commits] [PATCH] D135621: [lldb] Add an always-on log channel

clayborg added a comment. > It might be nice to also have a "diagnostics" log channel that _can_ be > enabled, and any diagnostic messages would then also be included in the log > output but only if enabled by the user? And if the logging gets enabled, we can write out all of the diagnostics an

[Lldb-commits] [PATCH] D135621: [lldb] Add an always-on log channel

clayborg added a comment. Maybe use LLDBLog::Diagnostics instead of LLDBLog::AlwaysOn? and maybe "diagnostics" instead of "always-on"? I am also questioning if the these even belong in the LLDB logging stuff? Seems like it would be just as easy to create a diagnostic message by calling Diagnos

[Lldb-commits] [PATCH] D135621: [lldb] Add an always-on log channel

JDevlieghere added a comment. In D135621#3849043 , @labath wrote: > I'm not sure if this will do what you wanted it to do. Despite the title, > this patch is not adding a new log *channel* -- it is adding a new log > *category* to the "lldb" channel. Ou

[Lldb-commits] [PATCH] D135621: [lldb] Add an always-on log channel

labath added a comment. I'm not sure if this will do what you wanted it to do. Despite the title, this patch is not adding a new log *channel* -- it is adding a new log *category* to the "lldb" channel. Our logging infra, perhaps somewhat misleadingly, manages all of the log state on a per-chan

[Lldb-commits] [PATCH] D135621: [lldb] Add an always-on log channel

JDevlieghere created this revision. JDevlieghere added reviewers: labath, DavidSpickett, jingham, mib, clayborg. Herald added a project: All. JDevlieghere requested review of this revision. Add an "always on" log channel. The channel is meant to be used sparsely and deliberately for logging high-