[Lldb-commits] [PATCH] D133906: [lldb] Generate lldb-forward with .def file

labath added a comment. In D133906#3792666 , @JDevlieghere wrote: > In D133906#3792230 , @labath wrote: > >> // no .def file >> #define LLDB_FORWARD_CLASS(cls) \ >> namespace lldb_private { class cls; } \

[Lldb-commits] [PATCH] D133906: [lldb] Generate lldb-forward with .def file

clayborg added a comment. I really wish the .def files would actually generate a header file in the output directory. I am not a fan of using code navigation when saying "take me to the definition of "class Block;" and it shows: #define LLDB_FORWARD_CLASS(Name) class Name; #include "lldb-fo

[Lldb-commits] [PATCH] D133906: [lldb] Generate lldb-forward with .def file

jingham added a comment. To some extent, the fact that we define an XxxSP for a class is saying "This is a thing we mostly pass around as a shared pointer" which would be lost if every time we make an SP or UP we use the same syntax. But I'm not sure that that's a terribly strong objection.

[Lldb-commits] [PATCH] D133906: [lldb] Generate lldb-forward with .def file

kastiglione added a comment. SP and UP templates seems fine to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133906/new/ https://reviews.llvm.org/D133906 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [PATCH] D133906: [lldb] Generate lldb-forward with .def file

JDevlieghere added a comment. In D133906#3792230 , @labath wrote: > In D133906#3791352 , @JDevlieghere > wrote: > >> In D133906#3791153 , @jingham >> wrote: >> >>> This

[Lldb-commits] [PATCH] D133906: [lldb] Generate lldb-forward with .def file

labath added a comment. In D133906#3791352 , @JDevlieghere wrote: > In D133906#3791153 , @jingham wrote: > >> This patch makes me a little sad because it breaks the "Jump to Definition" >> chain in Xcode (and I

[Lldb-commits] [PATCH] D133906: [lldb] Generate lldb-forward with .def file

JDevlieghere added a comment. In D133906#3791153 , @jingham wrote: > This patch makes me a little sad because it breaks the "Jump to Definition" > chain in Xcode (and I bet it does in other IDE's that support this.) You > used to be able to do "Jump to

[Lldb-commits] [PATCH] D133906: [lldb] Generate lldb-forward with .def file

mib accepted this revision. mib added a comment. In D133906#3791153 , @jingham wrote: > This patch makes me a little sad because it breaks the "Jump to Definition" > chain in Xcode (and I bet it does in other IDE's that support this.) You > used to be

[Lldb-commits] [PATCH] D133906: [lldb] Generate lldb-forward with .def file

mib added a comment. In D133906#3791153 , @jingham wrote: > This patch makes me a little sad because it breaks the "Jump to Definition" > chain in Xcode (and I bet it does in other IDE's that support this.) You > used to be able to do "Jump to Definiti

[Lldb-commits] [PATCH] D133906: [lldb] Generate lldb-forward with .def file

jingham added a comment. This patch makes me a little sad because it breaks the "Jump to Definition" chain Xcode (and I bet it does in other IDE's that support this.) You used to be able to do "Jump to Definition" on ProcessSP, then jump to definition on the class name in the shared pointer de

[Lldb-commits] [PATCH] D133906: [lldb] Generate lldb-forward with .def file

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Definitely better than the previous contents! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133906/new/ https://reviews.llvm.org/D133906 ___

[Lldb-commits] [PATCH] D133906: [lldb] Generate lldb-forward with .def file

JDevlieghere created this revision. JDevlieghere added reviewers: mib, aprantl, labath. Herald added a project: All. JDevlieghere requested review of this revision. Generate lldb-forward with .def file. The benefit is that we don't have to keep the list of classes, and typedefs in sync. https:/