jingham added a comment.

This patch makes me a little sad because it breaks the "Jump to Definition" 
chain Xcode (and I bet it does in other IDE's that support this.)  You used to 
be able to do "Jump to Definition" on ProcessSP, then jump to definition on the 
class name in the shared pointer definition to jump to the class.  Not the 
first jump takes you to:

LLDB_FORWARD_CLASS(Process)

in the lldb-forward.def file, and you can't go any further.  These .def 
insertions almost always make things harder to find in the actual code, so they 
aren't free.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133906/new/

https://reviews.llvm.org/D133906

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to