[Lldb-commits] [PATCH] D133639: [lldb] Fix detection of existing libcxx

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc04749957f1: [lldb] Fix detection of existing libcxx (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133639/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D133639: [lldb] Fix detection of existing libcxx

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133639/new/ https://reviews.llvm.org/D133639 __

[Lldb-commits] [PATCH] D133639: [lldb] Fix detection of existing libcxx

fdeazeve updated this revision to Diff 459474. fdeazeve edited the summary of this revision. fdeazeve added a comment. Addressed review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133639/new/ https://reviews.llvm.org/D133639 Files: lld

[Lldb-commits] [PATCH] D133639: [lldb] Fix detection of existing libcxx

JDevlieghere added inline comments. Comment at: lldb/test/API/lit.cfg.py:181-184 +if is_configured_and_true('has_libcxx') and platform.system() != 'Windows': if is_configured('llvm_include_dir') and is_configured('llvm_libs_dir'): dotest_cmd += ['--libcxx-include-dir', o

[Lldb-commits] [PATCH] D133639: [lldb] Fix detection of existing libcxx

fdeazeve updated this revision to Diff 459441. fdeazeve added a comment. Addressed review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133639/new/ https://reviews.llvm.org/D133639 Files: lldb/test/API/lit.cfg.py Index: lldb/test/API/l

[Lldb-commits] [PATCH] D133639: [lldb] Fix detection of existing libcxx

fdeazeve added inline comments. Comment at: lldb/test/API/lit.cfg.py:181-184 +if is_configured_and_true('has_libcxx') and platform.system() != 'Windows': if is_configured('llvm_include_dir') and is_configured('llvm_libs_dir'): dotest_cmd += ['--libcxx-include-dir', os.pa

[Lldb-commits] [PATCH] D133639: [lldb] Fix detection of existing libcxx

JDevlieghere added inline comments. Comment at: lldb/test/API/lit.cfg.py:94 +def is_configured_and_true(attr): + """Returns true if and only if the configuration attribute exists and it is `is_enabled` maybe? Comment at: lldb/test/API/lit.cf

[Lldb-commits] [PATCH] D133639: [lldb] Fix detection of existing libcxx

fdeazeve updated this revision to Diff 459348. fdeazeve edited the summary of this revision. fdeazeve added a comment. Reworded commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133639/new/ https://reviews.llvm.org/D133639 Files: lldb

[Lldb-commits] [PATCH] D133639: [lldb] Fix detection of existing libcxx

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The CMake variable LLDB_HAS_LIBCXX is passed to `llvm_canonicalize_cmake_booleans`, which transforms TRUE/FALSE into 1/0 a