Michael137 added a comment.
Herald added a subscriber: JDevlieghere.
LGTM thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133618/new/
https://reviews.llvm.org/D133618
___
lldb-commits mailing list
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2f4a66eed688: Adapt LLDB dataformatters for libcxx change
D129386 (authored by aprantl).
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Repository:
rG LLVM Github Monorepo
CHANG
aprantl added inline comments.
Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:1004
+ auto dataobj = GetChildMemberWithName(
+ valobj, {ConstString("__data_"), ConstString("__data")});
+ auto sizeobj = GetChildMemberWithName(
ldionne wrote:
>
ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.
Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:1004
+ auto dataobj = GetChildMemberWithName(
+ valobj, {ConstString("__data_"), ConstString("__data
aprantl updated this revision to Diff 459214.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133618/new/
https://reviews.llvm.org/D133618
Files:
lldb/include/lldb/DataFormatters/VectorIterator.h
lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp
lldb/source/Plugins/Language/CPlusPlus
aprantl created this revision.
aprantl added reviewers: Michael137, fdeazeve, ldionne, philnik.
Herald added a project: All.
aprantl requested review of this revision.
We at first misattributed this to a CMake configuration change that happened on
green dragon at the same time, hence the delay.
