aprantl added inline comments.

================
Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:1004
+  auto dataobj = GetChildMemberWithName(
+      valobj, {ConstString("__data_"), ConstString("__data")});
+  auto sizeobj = GetChildMemberWithName(
----------------
ldionne wrote:
> IIUC you're trying to support both the old and the new naming?
Yes, otherwise the matrix bot, which tests that LLDB can debug code compiled 
with older releases of clang (and libcxx) would fail. Currently it builds the 
testsuite with every other release since Clang 5.0

https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-matrix/


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133618/new/

https://reviews.llvm.org/D133618

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to