[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56f9cfe30c44: [lldb] Remove uses of six module (NFC) (authored by kastiglione). Changed prior to commit: https://reviews.llvm.org/D131304?vs=45200

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

kastiglione updated this revision to Diff 452007. kastiglione added a comment. Restore LLDB_USE_SYSTEM_SIX Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131304/new/ https://reviews.llvm.org/D131304 Files: lldb/bindings/interface/SBData.i lldb/

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

DavidSpickett added inline comments. Comment at: lldb/bindings/python/CMakeLists.txt:63-68 - if(NOT LLDB_USE_SYSTEM_SIX) -add_custom_command(TARGET ${swig_target} POST_BUILD VERBATIM - COMMAND ${CMAKE_COMMAND} -E copy -"${LLDB_SOURCE_DIR}/third_party/Python/modu

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. 🥳 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131304/new/ https://reviews.llvm.org/D131304 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

kastiglione added inline comments. Comment at: lldb/bindings/python/CMakeLists.txt:63-68 - if(NOT LLDB_USE_SYSTEM_SIX) -add_custom_command(TARGET ${swig_target} POST_BUILD VERBATIM - COMMAND ${CMAKE_COMMAND} -E copy -"${LLDB_SOURCE_DIR}/third_party/Python/module

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

kastiglione updated this revision to Diff 450843. kastiglione added a comment. Herald added a subscriber: mgorny. remove LLDB_USE_SYSTEM_SIX Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131304/new/ https://reviews.llvm.org/D131304 Files: lldb/b

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

DavidSpickett added a comment. There is also a cmake var `LLDB_USE_SYSTEM_SIX` which can be removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131304/new/ https://reviews.llvm.org/D131304 ___ lldb-co

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

kastiglione updated this revision to Diff 450668. kastiglione added a comment. Missed a restore of `str` variable name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131304/new/ https://reviews.llvm.org/D131304 Files: lldb/bindings/interface/SBDa

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

kastiglione added a comment. @mib the tests pass on my machine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131304/new/ https://reviews.llvm.org/D131304 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

kastiglione updated this revision to Diff 450444. kastiglione added a comment. Restore some "str" variable names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131304/new/ https://reviews.llvm.org/D131304 Files: lldb/bindings/interface/SBData.i

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

kastiglione added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:2278-2281 +assert not isinstance(patterns, str), \ "patterns must be a collection of strings" -assert not isinstance(substrs, six.string_types), \ +

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

mib added inline comments. Comment at: lldb/examples/python/scripted_process/scripted_process.py:5 -@six.add_metaclass(ABCMeta) -class ScriptedProcess: +class ScriptedProcess(metaclass=ABCMeta): mib wrote: > nit: no need to specify `metaclass=ABCMeta`, it can

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. Very cool! Thanks for taking care of this! LGTM with the 2 comments and assuming the test suite runs fine :) Comment at: lldb/examples/python/scripted_process/scripted_process.py:

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

kastiglione added a comment. I left `third_party/Python/module/six`, in case there are any lldb scripts that depend on the existence of `six`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131304/new/ https://reviews.llvm.org/D131304

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

kastiglione added inline comments. Comment at: lldb/packages/Python/lldbsuite/support/encoded_file.py:17-25 -def _encoded_read(old_read, encoding): -def impl(size): -result = old_read(size) -# If this is Python 2 then we need to convert the resulting `unicode`

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. With lldb (& llvm) requiring Python 3.6+, use of the `six`