kastiglione added inline comments.
================
Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:2278-2281
+ assert not isinstance(patterns, str), \
"patterns must be a collection of strings"
- assert not isinstance(substrs, six.string_types), \
+ assert not isinstance(substrs, str), \
"substrs must be a collection of strings"
----------------
mib wrote:
> kastiglione wrote:
> > this function had a parameter named `str`, which shadowed `builtin.str`. As
> > a fix, in this file I renamed all variables named `str` to `string`.
> nit: If you feel like it, may be you can split everything related to the
> `str`-> `string` refactor into a separate since it's orthogonal to removing
> `six`
I need to at least make the `str` -> `string` rename in the functions where the
refactor involves `isinstance(..., str)`. I will remove the other renames, for
another diff.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131304/new/
https://reviews.llvm.org/D131304
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
