[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add Register Info and Context

Emmmer added a comment. In D130342#3676318 , @DavidSpickett wrote: > Please note in the commit title/description that this is adding riscv64 only. > > Does this build if you don't have the rest of the changes from > https://reviews.llvm.org/D128250? Or

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add Register Info and Context

Emmmer updated this revision to Diff 447344. Emmmer added a comment. `case llvm::Triple::riscv64:` in `ArchSpec::CharIsSignedByDefault()` is unnecessary as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130342/new/ https://reviews.llvm.org/D130342 Files: lldb/source/Host/common

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add Register Info and Context

DavidSpickett added a comment. Please note in the commit title/description that this is adding riscv64 only. Does this build if you don't have the rest of the changes from https://reviews.llvm.org/D128250? Or do you plan to split out more from that and have this depend on those changes. (thank

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add Register Info and Context

Emmmer updated this revision to Diff 447322. Emmmer added a comment. > Why is this only needed for PECOFF? (maybe it is the only one that lists them > like this) At first, I tracked a bug from `LLDBServerTests` and thought that `GetArchitecture()` returned a wrong match, so I added `case llvm:

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add Register Info and Context

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:1347 case llvm::COFF::IMAGE_FILE_MACHINE_ARM64: + case llvm::COFF::IMAGE_FILE_MACHINE_RISCV64: ArchSpec arch; Why is this only needed for PECOFF?

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add Register Info and Context

Emmmer updated this revision to Diff 447189. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130342/new/ https://reviews.llvm.org/D130342 Files: lldb/source/Host/common/HostInfoBase.cpp lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp lldb/source/Plugins/Process/Linux/CMake

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add Register Info and Context

JDevlieghere added inline comments. Comment at: lldb/source/Utility/ArchSpec.cpp:1390-1395 + case ArchSpec::eCore_riscv64: +if (!enforce_exact_match) { + if (core2 == ArchSpec::eCore_riscv64) +return true; +} +break; I don't think this i

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add Register Info and Context

Emmmer updated this revision to Diff 446766. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130342/new/ https://reviews.llvm.org/D130342 Files: lldb/source/Host/common/HostInfoBase.cpp lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp lldb/source/Plugins/Process/Linux/CMake

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add Register Info and Context

Emmmer created this revision. Emmmer added reviewers: labath, DavidSpickett, JDevlieghere, jingham. Herald added subscribers: sunshaoce, VincentWu, luke957, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosb