JDevlieghere added inline comments.

================
Comment at: lldb/source/Utility/ArchSpec.cpp:1390-1395
+  case ArchSpec::eCore_riscv64:
+    if (!enforce_exact_match) {
+      if (core2 == ArchSpec::eCore_riscv64)
+        return true;
+    }
+    break;
----------------
I don't think this is needed. The case where the two cores are identical is 
already covered by line 1084. This would be for something like `eCore_riscv32` 
if that were a thing. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130342/new/

https://reviews.llvm.org/D130342

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to