[Lldb-commits] [PATCH] D128026: [lldb] Add a BufferedLogHandler

JDevlieghere abandoned this revision. JDevlieghere added a comment. With D127986 I don't think we need this anymore. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128026/new/ https://reviews.llvm.org/D128026 __

[Lldb-commits] [PATCH] D128026: [lldb] Add a BufferedLogHandler

clayborg added a comment. This is an interesting take that makes more sense than specifying a size in bytes and a "m_circular" since that kind of thing could cut the first message. Saving entire messages as they are logged might make more sense for our circular log messages as we would ensure w

[Lldb-commits] [PATCH] D128026: [lldb] Add a BufferedLogHandler

JDevlieghere added a comment. In D128026#3595457 , @labath wrote: > I feel I should note that the llvm streams already have a buffered mode, and > given the way things are implemented now (our log class writes the entire log > message in one call, and t

[Lldb-commits] [PATCH] D128026: [lldb] Add a BufferedLogHandler

labath added a comment. I feel I should note that the llvm streams already have a buffered mode, and given the way things are implemented now (our log class writes the entire log message in one call, and the raw_ostream flushing the entire buffer whenever a message does not fit), I don't think

[Lldb-commits] [PATCH] D128026: [lldb] Add a BufferedLogHandler

JDevlieghere updated this revision to Diff 437788. JDevlieghere added a comment. Flush on destruction CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128026/new/ https://reviews.llvm.org/D128026 Files: lldb/include/lldb/Utility/Log.h lldb/source/Utility/Log.cpp lldb/unittests/Utili

[Lldb-commits] [PATCH] D128026: [lldb] Add a BufferedLogHandler

JDevlieghere updated this revision to Diff 437784. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128026/new/ https://reviews.llvm.org/D128026 Files: lldb/include/lldb/Utility/Log.h lldb/source/Utility/Log.cpp lldb/unittests/Utility/LogTest.cpp Index: lldb/unittests/Utility/LogTes

[Lldb-commits] [PATCH] D128026: [lldb] Add a BufferedLogHandler

JDevlieghere created this revision. JDevlieghere added a reviewer: clayborg. Herald added a project: All. JDevlieghere requested review of this revision. Add a BufferedLogHandler as requested by Greg in D127986 . https://reviews.llvm.org/D128026 Files: lldb/