JDevlieghere added a comment. In D128026#3595457 <https://reviews.llvm.org/D128026#3595457>, @labath wrote:
> I feel I should note that the llvm streams already have a buffered mode, and > given the way things are implemented now (our log class writes the entire log > message in one call, and the raw_ostream flushing the entire buffer whenever > a message does not fit), I don't think this class has any advantages over > using stream buffering (that's a very long-winded way of saying you're not > going to get partial messages in either of the solutions). The only two > differences I see are: > > - one of them specifies the size, the other specifies the number of messages > - different behavior in case of races (in non-thread-safe mode). I'll write > more on that elsewhere. As I said in the other patch, I (personally) don't really care all that much about buffering except for the circular buffer. I've implemented an alterantive, stream based buffering approach in https://reviews.llvm.org/D127986. I'll put up a separate patch for the circular buffer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128026/new/ https://reviews.llvm.org/D128026 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
