[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

DavidSpickett added a comment. (I also keep an eye on the bots Omair was referring to) You can just reland this change as is (revert your revert) and if something else goes wrong you'll either get a failure email or we'll let you know. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

hawkinsw reopened this revision. hawkinsw added a comment. In D124731#3530692 , @omjavaid wrote: > I have reverted this temporarily as It broke LLDB API test > TestBadAddressBreakpoints.py @omjavaid We have updated that test so that this should no longe

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

omjavaid added a comment. I have reverted this temporarily as It broke LLDB API test TestBadAddressBreakpoints.py Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124731/new/ https://reviews.llvm.org/D124731 _

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

hawkinsw added a comment. I realize the reason for the failure. It would appear that there are tests that are otherwise affected by the change in the behavior introduced here. I will take care of updating these tests as quickly as possible. I am sorry for the trouble, @JDevlieghere ! Reposito

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

hawkinsw added a comment. I am going to investigate why the buildbot failed. When I ran the tests locally everything ran fine. I am terribly, terribly sorry! @JDevlieghere -- If you could help me debug the failure, or point me to the documentation on how to read buildbot output, that would be g

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGa3c3482ceb52: [lldb] Consider binary as module of last resort (authored by hawkinsw, committed by JDevlieghere). Reposito

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

hawkinsw added a comment. In D124731#3528269 , @JDevlieghere wrote: > Please let me know if you need someone to land this on your behalf. Unfortunately, I do! Sorry! I have not yet completed the committer process. I still feel too new. Thanks for the m

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

JDevlieghere added a comment. Please let me know if you need someone to land this on your behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124731/new/ https://reviews.llvm.org/D124731 ___ lldb-commi

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

JDevlieghere accepted this revision. JDevlieghere added a comment. No worries, thank you for your patience. This LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124731/new/ https://reviews.llvm.org/D124731 _

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

hawkinsw marked 2 inline comments as done. hawkinsw added a comment. @JDevlieghere So sorry! I cannot believe I missed those. Thanks for putting up with me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124731/new/ https://reviews.llvm.org/D124731

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

hawkinsw updated this revision to Diff 430781. hawkinsw added a comment. Stupidly missed a few of the places where bare assertions were used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124731/new/ https://reviews.llvm.org/D124731 Files: lldb/

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

JDevlieghere added a comment. Still a few places where we have a dedicated assert Comment at: lldb/test/API/commands/breakpoint/set/address-nomodule/TestBreakpointAddressNoModule.py:25 +debugger.HandleCommand(f"break set -a {main_address:#x}") +self.assertTrue(

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

hawkinsw added a comment. Just wanted to see if there was anything else I could do to help make this patch acceptable, @JDevlieghere and @jingham . Thanks again for all your help! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124731/new/ https://r

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

hawkinsw added a comment. @JDevlieghere Thanks again for the feedback. I updated the patchset according to your comments. I left open one of your suggestions to get your feedback. Thanks again! Will Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

hawkinsw updated this revision to Diff 429411. hawkinsw added a comment. Updating the patchset according to the helpful feedback from @jdevlieghere. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124731/new/ https://reviews.llvm.org/D124731 Files:

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

hawkinsw marked 5 inline comments as done. hawkinsw added inline comments. Comment at: lldb/test/API/commands/breakpoint/set/address-nomodule/TestBreakpointAddressNoModule.py:11 +def get_address_from_symbol(self, symbol): +target = lldbutil.run_to_breakpoint_make_tar

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

JDevlieghere added inline comments. Comment at: lldb/test/API/commands/breakpoint/set/address-nomodule/TestBreakpointAddressNoModule.py:11 +def get_address_from_symbol(self, symbol): +target = lldbutil.run_to_breakpoint_make_target(self, "a.out", True) +bp =

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

hawkinsw added a comment. Hello @labath and @JDevlieghere -- I hope that your Friday is going well! I'd love to make any other changes to this if necessary! Thanks for everything! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124731/new/ https://r

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

hawkinsw added a comment. Sorry to bother you all (@jingham, @JDevlieghere and @labath), but I just wondered if there was anything else that I could do to spruce this up! I want to make sure that it meets everyone's expectations! It's been awesome to work on this submission! Will Repository

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

hawkinsw added a comment. In D124731#3498195 , @hawkinsw wrote: > (for real) Updating the patch based on helpful feedback from @jingham. I used to know better how to make sure that phabricator notified people that the commit was updated based on their f

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

hawkinsw updated this revision to Diff 427794. hawkinsw added a comment. (for real) Updating the patch based on helpful feedback from @jingham. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124731/new/ https://reviews.llvm.org/D124731 Files: lld

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

hawkinsw updated this revision to Diff 427791. hawkinsw added a comment. Updated patch including responses to helpful feedback from @jingham. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124731/new/ https://reviews.llvm.org/D124731 Files: lldb/

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

hawkinsw added a comment. In D124731#3494609 , @jingham wrote: > This seems like a reasonable fallback, and the implementation looks fine. > You need to add a test case setting an address breakpoint in the executable > and making sure that works. Should

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. This seems like a reasonable fallback, and the implementation looks fine. You need to add a test case setting an address breakpoint in the executable and making sure that works. Sh

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

JDevlieghere added a comment. This looks reasonable to me, but I'm not sure if there's anything special about the executable module that would result in us doing the wrong thing. I'm sure Jim or Pavel will know. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

hawkinsw added a comment. First, a thank you from a long-time `gdb` user who has finally seen the light and working to switch to `lldb`! The work that you all do to build an awesome, modern debugger is amazing. As for this patch, I have committed a few typo fixes in the past, but this is my fi

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

hawkinsw created this revision. hawkinsw added reviewers: tatyana-krasnukha, jingham. Herald added a project: All. hawkinsw requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When setting an address breakpoint using a non-section address in ll