[Lldb-commits] [PATCH] D122975: parallelize calling of Module::PreloadSymbols()

labath added a comment. In D122975#3500176 , @labath wrote: > or rethink the do-tasks-while-you-wait idea. I suppose one way to fix this would be to ensure that the waiting thread only picks up its own subtasks while its waiting. That would avoid these

[Lldb-commits] [PATCH] D122975: parallelize calling of Module::PreloadSymbols()

labath added a comment. I'm afraid I had to revert this, as it was causing hangs in TestMultipleDebuggers.py. I haven't fully debugged this, but what I think is happening is this: - the test debug multiple (identical) inferiors in parallel - as a result the thread pool gets hit with many preloa

[Lldb-commits] [PATCH] D122975: parallelize calling of Module::PreloadSymbols()

This revision was automatically updated to reflect the committed changes. Closed by commit rGb7d807dbcff0: [lldb] parallelize calling of Module::PreloadSymbols() (authored by llunak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122975/new/ https:/

[Lldb-commits] [PATCH] D122975: parallelize calling of Module::PreloadSymbols()

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Awesome. Thanks for your patience. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122975/new/ https://reviews.llvm.org/D122975 ___ lldb-com

[Lldb-commits] [PATCH] D122975: parallelize calling of Module::PreloadSymbols()

llunak added a comment. The prerequisities fo this change have been pushed, so this one is ready. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122975/new/ https://reviews.llvm.org/D122975 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D122975: parallelize calling of Module::PreloadSymbols()

llunak updated this revision to Diff 423247. llunak added a comment. Adapted to API changes from D123225 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122975/new/ https://reviews.llvm.org/D122975 Files: lldb/source/Target/Target.cpp Index: lldb/s

[Lldb-commits] [PATCH] D122975: parallelize calling of Module::PreloadSymbols()

llunak updated this revision to Diff 420885. llunak added a comment. Rebased on ThreadPool groups (D123225 ) and adding such thread pool to LLDB (D123226 ). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122975/new/ htt

[Lldb-commits] [PATCH] D122975: parallelize calling of Module::PreloadSymbols()

llunak added a comment. In D122975#3430613 , @JDevlieghere wrote: > After applying this patch I started seeing data races reported by TSan when > running the shell tests (`check-lldb-shell`). It seems to happen to different > tests on different runs bu

[Lldb-commits] [PATCH] D122975: parallelize calling of Module::PreloadSymbols()

JDevlieghere added a comment. After applying this patch I started seeing data races reported by TSan when running the shell tests (`check-lldb-shell`). It seems to happen to different tests on different runs but the backtraces are the same. WARNING: ThreadSanitizer: data race (pid=40880)

[Lldb-commits] [PATCH] D122975: parallelize calling of Module::PreloadSymbols()

llunak updated this revision to Diff 420492. llunak retitled this revision from "parallelize module loading in DynamicLoaderPOSIXDYLD()" to "parallelize calling of Module::PreloadSymbols()". llunak edited the summary of this revision. llunak added a reviewer: jingham. llunak added a comment. Ok,