This revision was automatically updated to reflect the committed changes.
Closed by commit rL244738: Download symbol file for .oat files on android
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D11936?vs=31826&id=31922#toc
Repository:
rL LLVM
http://reviews.llv
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: source/Utility/ModuleCache.cpp:207
@@ +206,3 @@
+
+FileSpec symfile_spec((cached_module_sp->GetFileSpec ().GetPath () +
".sym").c_str (), false);
+
tberghammer added a comment.
See responds inline
Comment at: source/Plugins/Platform/Android/PlatformAndroid.cpp:325
@@ +324,3 @@
+ &tmpdir,
+ 1);
+
ovyalov wrote:
> Please add constant for timeou
tberghammer updated this revision to Diff 31826.
tberghammer marked 8 inline comments as done.
tberghammer added a comment.
Address comments
http://reviews.llvm.org/D11936
Files:
include/lldb/Target/Platform.h
source/Plugins/Platform/Android/PlatformAndroid.cpp
source/Plugins/Platform/And
ovyalov added a comment.
Please see my comments.
Comment at: source/Plugins/Platform/Android/PlatformAndroid.cpp:306
@@ +305,3 @@
+if (!module_sp->GetPlatformFileSpec())
+return Error("No platform file specified");
+
indentation.
Co
tberghammer created this revision.
tberghammer added a reviewer: ovyalov.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
Download symbol file for .oat files on android
On android .oat files (compiled java code) don't have symbol
informatio
