[Lldb-commits] [PATCH] D118473: [lldb] [Commands] Implement "thread siginfo"

mgorny added a comment. Thanks for all the reviews and helpful suggestions! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118473/new/ https://reviews.llvm.org/D118473 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D118473: [lldb] [Commands] Implement "thread siginfo"

This revision was automatically updated to reflect the committed changes. Closed by commit rG287ce6b51675: [lldb] [Commands] Implement "thread siginfo" (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D118473: [lldb] [Commands] Implement "thread siginfo"

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This looks fine to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118473/new/ https://reviews.llvm.org/D118473 ___ lldb-commits maili

[Lldb-commits] [PATCH] D118473: [lldb] [Commands] Implement "thread siginfo"

mgorny updated this revision to Diff 405249. mgorny marked an inline comment as done. mgorny added a comment. Removed the comment and added `thread info`-style status above siginfos. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118473/new/ https://reviews.llvm.org/D118473 Files: lld

[Lldb-commits] [PATCH] D118473: [lldb] [Commands] Implement "thread siginfo"

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: lldb/source/Commands/CommandObjectThread.cpp:1323 +// CommandObjectThreadSiginfo + JDevlieghere wrote: > I know you're just being consistent with the rest of this file, but we'v

[Lldb-commits] [PATCH] D118473: [lldb] [Commands] Implement "thread siginfo"

JDevlieghere added inline comments. Comment at: lldb/source/Commands/CommandObjectThread.cpp:1323 +// CommandObjectThreadSiginfo + I know you're just being consistent with the rest of this file, but we've been slowly phasing out these kind of comments. CHAN

[Lldb-commits] [PATCH] D118473: [lldb] [Commands] Implement "thread siginfo"

jingham added a comment. I think it would help readability if you put the thread ID for the signinfo before printing the siginfo value, otherwise if I list multiple threads (or use "all") I have to count instances to figure out which thread goes with which siginfo. Otherwise this looks fine.

[Lldb-commits] [PATCH] D118473: [lldb] [Commands] Implement "thread siginfo"

labath added a reviewer: jingham. labath added a comment. Seems reasonable to me, but let's get Jim's opinion too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118473/new/ https://reviews.llvm.org/D118473 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D118473: [lldb] [Commands] Implement "thread siginfo"

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. mgorny requested review of this revision. https://reviews.llvm.org/D118473 Files: lldb/source/Commands/CommandObjectThread.cpp lldb/test/Shell/Commands/Inputs/sigchld.c lldb/test/Shell/Commands/command-thread