jingham added a comment. I think it would help readability if you put the thread ID for the signinfo before printing the siginfo value, otherwise if I list multiple threads (or use "all") I have to count instances to figure out which thread goes with which siginfo.
Otherwise this looks fine. ================ Comment at: lldb/source/Commands/CommandObjectThread.cpp:1355 + + Stream &strm = result.GetOutputStream(); + ValueObjectSP exception_object_sp = thread_sp->GetSiginfoValue(); ---------------- The CommandObjectIterateOverThreads class doesn't itself print which thread the output of each HandleOneThread is for, so if I did: (lldb) thread siginfo all Then I would just get a bunch of undifferentiated siginfo's and wouldn't have a way to figure out which thread went with which output. I think it would help to repeat the thread name before the siginfo output. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118473/new/ https://reviews.llvm.org/D118473 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
