[Lldb-commits] [PATCH] D112709: [lldb] Fix matchers for char array formatters

aprantl added a comment. > it can vary on some platforms it is signed char but on others it is bool. For those interested, Objective-C `BOOL` is a signed char on macOS and 32-bit iOS and `bool` on 64-bit iOS and derived platforms (watchOS & tvOS). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D112709: [lldb] Fix matchers for char array formatters

labath added a comment. Thanks for the heads up. I've reverted the problematic parts in 31c7165a2b . I'll come with a proper fix soon-ish. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D112709: [lldb] Fix matchers for char array formatters

shafik added a subscriber: aprantl. shafik added a comment. In D112709#3223098 , @shafik wrote: > Because `BOOL` is actually a `signed char` @aprantl corrected me, it can vary on some platforms it is `signed char` but on others it is `bool`. Repositor

[Lldb-commits] [PATCH] D112709: [lldb] Fix matchers for char array formatters

shafik added a comment. Because `BOOL` is actually a `signed char` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112709/new/ https://reviews.llvm.org/D112709 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D112709: [lldb] Fix matchers for char array formatters

shafik added a comment. Pavel, I apologize no one let you know earlier but it looks like this change broke `TestFormattersBoolRefPtr.py` test. see: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/39449/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D112709: [lldb] Fix matchers for char array formatters

This revision was automatically updated to reflect the committed changes. Closed by commit rG11dc235c7dda: [lldb] Fix matchers for char array formatters (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112709/new/ https://reviews.

[Lldb-commits] [PATCH] D112709: [lldb] Fix matchers for char array formatters

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. The substance is fine, you kept the common cases fast and then added fallback for the others with the regex. That test seems like an object lesson in what not to do in an inline test, but t

[Lldb-commits] [PATCH] D112709: [lldb] Fix matchers for char array formatters

labath added a comment. @jingham, @shafik, do you see any issues with this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112709/new/ https://reviews.llvm.org/D112709 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D112709: [lldb] Fix matchers for char array formatters

labath added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112709/new/ https://reviews.llvm.org/D112709 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg

[Lldb-commits] [PATCH] D112709: [lldb] Fix matchers for char array formatters

labath added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/stringprinter/main.cpp:21 +MAKE_VARS(); +MAKE_VARS(const); + shafik wrote: > It feels like writing out the decls by hand would have been quicker but > perhaps less satisfying

[Lldb-commits] [PATCH] D112709: [lldb] Fix matchers for char array formatters

shafik added a comment. Nice catch! Comment at: lldb/test/API/functionalities/data-formatter/stringprinter/main.cpp:21 +MAKE_VARS(); +MAKE_VARS(const); + It feels like writing out the decls by hand would have been quicker but perhaps less satisfying... Repo

[Lldb-commits] [PATCH] D112709: [lldb] Fix matchers for char array formatters

labath created this revision. labath added reviewers: teemperor, jingham. labath requested review of this revision. Herald added a project: LLDB. They were being applied too narrowly (they didn't cover signed char *, for instance), and too broadly (they covered SomeTemplate) at the same time. Dep