jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land.
The substance is fine, you kept the common cases fast and then added fallback for the others with the regex. That test seems like an object lesson in what not to do in an inline test, but that wasn't your invention, so it's hard to complain too much. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112709/new/ https://reviews.llvm.org/D112709 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
