[Lldb-commits] [PATCH] D112165: Cleanup a few more PR36048 skips

dblaikie added a comment. In D112165#3102055 , @teemperor wrote: > In D112165#3100929 , @dblaikie > wrote: > >> In D112165#3100608 , @teemperor >> wrote: >> >>> Small no

[Lldb-commits] [PATCH] D112165: Cleanup a few more PR36048 skips

labath added a comment. Actually, I've successfully purged most of this from my memory. However, what Raphael said is consistent with what little I remember. It would be better if the gmodules tests had their own (semi-)dedicated tests that were independent of the system libraries. Then, they c

[Lldb-commits] [PATCH] D112165: Cleanup a few more PR36048 skips

teemperor added a subscriber: labath. teemperor added a comment. In D112165#3100929 , @dblaikie wrote: > In D112165#3100608 , @teemperor > wrote: > >> Small note: gmodules test are never run on Linux, so you actu

[Lldb-commits] [PATCH] D112165: Cleanup a few more PR36048 skips

dblaikie added a comment. In D112165#3100608 , @teemperor wrote: > Small note: gmodules test are never run on Linux, so you actually have to run > them on macOS (or I think FreeBSD) to know whether the tests work. Yeah, I'll admit I didn't test this, bu

[Lldb-commits] [PATCH] D112165: Cleanup a few more PR36048 skips

teemperor added a comment. Small note: gmodules test are never run on Linux, so you actually have to run them on macOS (or I think FreeBSD) to know whether the tests work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112165/new/ https://reviews.l

[Lldb-commits] [PATCH] D112165: Cleanup a few more PR36048 skips

This revision was automatically updated to reflect the committed changes. Closed by commit rGe6b323379e31: Cleanup a few more PR36048 skips (authored by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112165/new/ https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D112165: Cleanup a few more PR36048 skips

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112165/new/ https://reviews.llvm.org/D112165

[Lldb-commits] [PATCH] D112165: Cleanup a few more PR36048 skips

dblaikie created this revision. dblaikie added a reviewer: aprantl. dblaikie requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Hopefully these were also fixed bi r343545 / 7fd4513920d2fed533ad420976529ef43eb42a35 Repository: rG LLVM Githu