dblaikie added a comment.

In D112165#3100608 <https://reviews.llvm.org/D112165#3100608>, @teemperor wrote:

> Small note: gmodules test are never run on Linux, so you actually have to run 
> them on macOS (or I think FreeBSD) to know whether the tests work.

Yeah, I'll admit I didn't test this, but seemed consistent with the other 
changes/cleanup - did this cause any breakage you know of?

Could gmodules be tested on Linux? (I had originally really hoped/tried to 
encourage gmodules to be implemented in a way that'd be compatible with Split 
DWARF but it never quite got there, unfortunately... would've made more overlap 
in functionality/testability/portability, I think)

(I should setup a build environment on my Macbook Pro, but haven't got around 
to it as yet)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112165/new/

https://reviews.llvm.org/D112165

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to