[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

This revision was automatically updated to reflect the committed changes. Closed by commit rGd5629b5d4d41: Fix rendezvous for rebase_exec=true case (authored by emrekultursay, committed by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109797

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay added a comment. Done. Can you also submit it please? Comment at: lldb/test/API/functionalities/dlopen/main.cpp:26 + // dlopen the 'liblib_b.so' shared library. + void* h = dlopen(solib, RTLD_LAZY); + assert(h && "dlopen failed?"); labath wrote

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay updated this revision to Diff 374536. emrekultursay marked 4 inline comments as done. emrekultursay added a comment. Renamed test to load_after_attach. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109797/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm, modulo comments. Comment at: lldb/test/API/functionalities/dlopen/TestDlopen.py:1 +import lldb +from lldbsuite.test.decorators import * I'd put this un

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay marked 3 inline comments as done. emrekultursay added a comment. PTAL. The test now passes on Linux, MacOS, and Windows. Comment at: lldb/test/API/functionalities/dlopen/main.cpp:26 + // dlopen the 'liblib_b.so' shared library. + void* h = dlopen(solib, RTLD_LAZ

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay updated this revision to Diff 374237. emrekultursay edited the summary of this revision. emrekultursay added a comment. Make test also run on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109797/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

labath added a comment. The test looks mostly fine. I made some comments on how to make it compatible with windows. I'm not sure if it would be enough to make it run there, but I think it has a fair chance. I might just let it run and then disable it if it turns out to be failing. ==

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay added a comment. plabath/mgorny: This change is ready for another round of review. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109797/new/ https://reviews.llvm.org/D109797 ___ ll

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay updated this revision to Diff 374027. emrekultursay added a comment. Minor fix in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109797/new/ https://reviews.llvm.org/D109797 Files: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay updated this revision to Diff 374026. emrekultursay added a comment. Update test to pass on MacOS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109797/new/ https://reviews.llvm.org/D109797 Files: lldb/source/Plugins/DynamicLoader/P

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay added a comment. In D109797#3005885 , @labath wrote: > I'm not sure all of this is relevant. I've just tried to debug a very simple > (linux) executable that does a dlopens a library. If I attach to the > executable before the dlopen call,

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay updated this revision to Diff 373560. emrekultursay added a comment. Minor touch-ups to the newly added test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109797/new/ https://reviews.llvm.org/D109797 Files: lldb/source/Plugins/Dyn

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay updated this revision to Diff 373559. emrekultursay added a comment. Add new dlopen test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109797/new/ https://reviews.llvm.org/D109797 Files: lldb/source/Plugins/DynamicLoader/POSIX-DYLD

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

labath added a comment. In D109797#3004232 , @emrekultursay wrote: > In D109797#3003265 , @labath wrote: > >> Since the meaning of `m_initial_modules_added` is basically "should I do a >> full scan through the l

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay added a comment. In D109797#3003265 , @labath wrote: > Since the meaning of `m_initial_modules_added` is basically "should I do a > full scan through the linked list" and LoadAllCurrentModules (called from > DidAttach) does a full scan, it

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay updated this revision to Diff 372982. emrekultursay added a comment. Added m_initial_modules_added=true into LoadAllCurrentModules. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109797/new/ https://reviews.llvm.org/D109797 Files: l

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

labath added a comment. Since the meaning of `m_initial_modules_added` is basically "should I do a full scan through the linked list" and LoadAllCurrentModules (called from DidAttach) does a full scan, it seems to me the real bug is that this function does not set `m_initial_modules_added = tru

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay updated this revision to Diff 372711. emrekultursay added a comment. Applied clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109797/new/ https://reviews.llvm.org/D109797 Files: lldb/source/Plugins/DynamicLoader/POSIX-DYL

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

mgorny added a comment. Ok, I don't see any obvious regressions while testing, so LGTM modulo formatting changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109797/new/ https://reviews.llvm.org/D109797 _

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

mgorny added a comment. I'm going to test this on FreeBSD in a minute. Could you fix clang-formatting in the meantime? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109797/new/ https://reviews.llvm.org/D109797

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay created this revision. emrekultursay requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When rebase_exec=true in DidAttach(), all modules are loaded before the rendezvous breakpoint is set, which means the LoadInterpreterModule()