https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/157530
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -519,8 +591,9 @@ int main(int argc, char *argv[]) {
Socket::SocketProtocol protocol;
std::string name;
std::tie(protocol, name) = *maybeProtoclAndName;
-if (auto Err = serveConnection(protocol, name, log.get(),
default_repl_mode,
-
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/156803
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/156803
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo commented:
add the documentation and i'll approve this :)
I also request a minor change
https://github.com/llvm/llvm-project/pull/156803
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.or
https://github.com/walter-erquinigo commented:
pretty nice. I just left a minor comment
https://github.com/llvm/llvm-project/pull/157530
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
@@ -32,6 +34,9 @@ void SendContinuedEvent(DAP &dap);
void SendProcessExitedEvent(DAP &dap, lldb::SBProcess &process);
+void SendInvalidatedEvent(
walter-erquinigo wrote:
Add documention and mention that `areas` is moved within the function.
I also think it m
walter-erquinigo wrote:
thanks!
https://github.com/llvm/llvm-project/pull/157150
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
connection-timeout seems to be a better name. I'll wait for the current
discussions to finish before reviewing again
https://github.com/llvm/llvm-project/pull/156803
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
walter-erquinigo wrote:
This change is not ideal. Instead, just define a default constructor for the
struct. Otherwise every time someone creates a new Symbol object, they'll have
to initialize it manually.
https://github.com/llvm/llvm-project/pull/156956
__
@@ -283,6 +283,21 @@ serveConnection(const Socket::SocketProtocol &protocol,
const std::string &name,
g_loop.AddPendingCallback(
[](MainLoopBase &loop) { loop.RequestTermination(); });
});
+ static MainLoopBase::TimePoint ttl_time_point;
+ static std::mutex ttl
walter-erquinigo wrote:
@royitaqi , watch for flaky issues these days just in case
https://github.com/llvm/llvm-project/pull/156231
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
cool
https://github.com/llvm/llvm-project/pull/156231
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/156803
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -327,6 +348,23 @@ serveConnection(const Socket::SocketProtocol &protocol,
const std::string &name,
std::unique_lock lock(dap_sessions_mutex);
dap_sessions.erase(&loop);
std::notify_all_at_thread_exit(dap_sessions_condition, std::move(lock));
+
+ if (t
@@ -61,3 +61,10 @@ def pre_init_command: S<"pre-init-command">,
def: Separate<["-"], "c">,
Alias,
HelpText<"Alias for --pre-init-command">;
+
+def time_to_live: S<"time-to-live">,
+ MetaVarName<"">,
+ HelpText<"When using --connection, the number of milliseconds t
@@ -283,6 +283,21 @@ serveConnection(const Socket::SocketProtocol &protocol,
const std::string &name,
g_loop.AddPendingCallback(
[](MainLoopBase &loop) { loop.RequestTermination(); });
});
+ static MainLoopBase::TimePoint ttl_time_point;
+ static std::mutex ttl
@@ -61,3 +61,10 @@ def pre_init_command: S<"pre-init-command">,
def: Separate<["-"], "c">,
Alias,
HelpText<"Alias for --pre-init-command">;
+
+def time_to_live: S<"time-to-live">,
+ MetaVarName<"">,
+ HelpText<"When using --connection, the number of milliseconds t
@@ -283,6 +283,21 @@ serveConnection(const Socket::SocketProtocol &protocol,
const std::string &name,
g_loop.AddPendingCallback(
[](MainLoopBase &loop) { loop.RequestTermination(); });
});
+ static MainLoopBase::TimePoint ttl_time_point;
walter-
@@ -283,6 +283,21 @@ serveConnection(const Socket::SocketProtocol &protocol,
const std::string &name,
g_loop.AddPendingCallback(
[](MainLoopBase &loop) { loop.RequestTermination(); });
});
+ static MainLoopBase::TimePoint ttl_time_point;
+ static std::mutex ttl
walter-erquinigo wrote:
Good, this looks good to me!
I'll let @kusmour do the final approval
https://github.com/llvm/llvm-project/pull/156231
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
@@ -450,6 +450,20 @@ def disassemble(self, threadId=None, frameIndex=None):
return disassembled_instructions,
disassembled_instructions[memoryReference]
+def dapCleanup(self, disconnectAutomatically):
+if disconnectAutomatically:
+try:
---
walter-erquinigo wrote:
do you know if destroying the debugger will free the module cache?
https://github.com/llvm/llvm-project/pull/156231
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
https://github.com/walter-erquinigo approved this pull request.
seems well done
https://github.com/llvm/llvm-project/pull/156131
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/155335
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
well, this looks good to me. Thanks!
https://github.com/llvm/llvm-project/pull/153536
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/155097
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
lgtm!
https://github.com/llvm/llvm-project/pull/151884
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
thanks!
https://github.com/llvm/llvm-project/pull/155238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
Thank you for the attention to details :) This is what makes this IDE great!
https://github.com/llvm/llvm-project/pull/155097
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http
@@ -227,3 +228,46 @@ def test_terminate_commands(self):
pattern=terminateCommands[0],
)
self.verify_commands("terminateCommands", output, terminateCommands)
+
+def test_session_id_update(self):
+program = self.build_and_create_debug_adapt
@@ -594,6 +594,20 @@ class CancelRequestHandler : public
RequestHandler> {
+public:
+ using RequestHandler::RequestHandler;
+ static llvm::StringLiteral GetCommand() { return "moduleSymbols"; }
walter-erquinigo wrote:
Good suggestion. I've been trying to use t
walter-erquinigo wrote:
This lgtm, please get a final approval from @ashgti
https://github.com/llvm/llvm-project/pull/153836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/153836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -324,6 +324,8 @@ class LLDB_API SBTarget {
lldb::SBModule FindModule(const lldb::SBFileSpec &file_spec);
+ lldb::SBModule FindModule(const lldb::SBModuleSpec &module_spec);
walter-erquinigo wrote:
I think I didn't explain myself clearly. I just wanted
@@ -0,0 +1,193 @@
+import * as vscode from "vscode";
+import { DebugProtocol } from "@vscode/debugprotocol";
+
+import { DebugSessionTracker } from "../debug-session-tracker";
+import { DisposableContext } from "../disposable-context";
+
+import { DAPSymbolType } from "..";
+impor
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/153536
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -157,6 +157,61 @@ async function getDAPArguments(
.get("arguments", []);
}
+/**
+ * Retrieves the environment that will be provided to lldb-dap either from
settings or the provided
+ * {@link vscode.DebugConfiguration}.
+ *
+ * @param workspaceFolder The {@link vscode.
https://github.com/walter-erquinigo approved this pull request.
just a minor thing and then good to go
https://github.com/llvm/llvm-project/pull/153536
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
walter-erquinigo wrote:
Yes, could you split this path into smaller ones? That's more standard for LLDB
https://github.com/llvm/llvm-project/pull/150777
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
https://github.com/walter-erquinigo approved this pull request.
this overall looks good to me
https://github.com/llvm/llvm-project/pull/148061
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lld
@@ -301,6 +301,14 @@ Variable CreateVariable(lldb::SBValue v, int64_t var_ref,
bool format_hex,
if (lldb::addr_t addr = v.GetLoadAddress(); addr != LLDB_INVALID_ADDRESS)
var.memoryReference = addr;
+ bool is_readonly = v.GetType().IsAggregateType() ||
https://github.com/walter-erquinigo approved this pull request.
thanks!
https://github.com/llvm/llvm-project/pull/151828
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/151884
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
Thank you @kazutakahirata !!! You are a life saver
https://github.com/llvm/llvm-project/pull/152170
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/152170
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
It seems that the CI linux tests is borked:
> cp: cannot stat
> '/home/gha/actions-runner/_work/llvm-project/llvm-project/build/test-results.*.xml':
> No such file or directory
I'll merge this for the time being
https://github.com/llvm/llvm-project/pull/152170
___
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/152170
…rotocol
When writing a custom gdb-remote server I realized that the encoder and decoder
of register formats is incomplete.
- Add the encoder on the server side and add an llvm_unreachable is there's
https://github.com/walter-erquinigo requested changes to this pull request.
Please write a section in the lldb-dap documentation on how to integrate with
other debugger extensions via these commands?
https://github.com/llvm/llvm-project/pull/151827
__
https://github.com/walter-erquinigo approved this pull request.
I really like this approach for composability. Thanks!
https://github.com/llvm/llvm-project/pull/151827
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi
@@ -301,6 +301,14 @@ Variable CreateVariable(lldb::SBValue v, int64_t var_ref,
bool format_hex,
if (lldb::addr_t addr = v.GetLoadAddress(); addr != LLDB_INVALID_ADDRESS)
var.memoryReference = addr;
+ bool is_readonly = v.GetType().IsAggregateType() ||
https://github.com/walter-erquinigo requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/151884
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
good catch
https://github.com/llvm/llvm-project/pull/152002
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -39,8 +39,10 @@ export class LLDBDapServer implements vscode.Disposable {
const process = child_process.spawn(dapPath, dapArgs, options);
process.on("error", (error) => {
reject(error);
-this.serverProcess = undefined;
-this.serverInfo = u
https://github.com/walter-erquinigo requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/151828
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
I somehow think we shouldn't add this kind of heuristics in LLDB and instead
add them in the VSCode extension at a per-language basis. Some language, like
Mojo, allow you to write variables with potentially any character sequences,
and they have different characters to
https://github.com/walter-erquinigo approved this pull request.
I'm back to review-land. Glad to see this kind of refactors happening :)
https://github.com/llvm/llvm-project/pull/147611
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://
walter-erquinigo wrote:
Just throwing out some ideas that might simplify this.
Is it possible to do the launching and attaching in asynchronous mode so that
the stop events are always emitted?
Also, the configuration done event can be emitted at any time during
initialization. It could even b
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/129728
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -28,15 +28,12 @@ def test_completions(self):
self.set_source_breakpoints(source, [breakpoint1_line,
breakpoint2_line])
-self.assertEvaluate(
-"`command regex user_command s/^$/platform/", r"\(lldb\) command
regex"
-)
-self.asse
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/135544
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
LGTM. Let's see if Jonas has more comments
https://github.com/llvm/llvm-project/pull/135008
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
@@ -164,7 +164,8 @@ void EvaluateRequestHandler::operator()(
dap.focus_tid = frame.GetThread().GetThreadID();
}
auto result = RunLLDBCommandsVerbatim(dap.debugger, llvm::StringRef(),
- {std::string(expression)});
+
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/135008
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
Probably the default is Auto. I guess we should add an option in the typescript
code for selecting the mode.
And about `:`, I confused you because I set up my debugger to use `:` instead
of a backtick.
In this mode, I think it would be great to determine via a quick p
https://github.com/walter-erquinigo requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/134722
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -116,7 +116,22 @@ void DisassembleRequestHandler::operator()(
const auto inst_count =
GetInteger(arguments, "instructionCount").value_or(0);
- lldb::SBInstructionList insts = dap.target.ReadInstructions(addr,
inst_count);
+
+ std::string flavor_string{};
+ const
@@ -116,7 +116,22 @@ void DisassembleRequestHandler::operator()(
const auto inst_count =
GetInteger(arguments, "instructionCount").value_or(0);
- lldb::SBInstructionList insts = dap.target.ReadInstructions(addr,
inst_count);
+
+ std::string flavor_string{};
+ const
walter-erquinigo wrote:
@da-viper , I'm a bit surprised by this. Which mode are you using for the
debug console?
I remember that in Variable mode (or whichever is the default), I was able to
type `:expr ` and that worked.
Is your problem occurring in the Auto mode? I think that in this case,
@@ -0,0 +1,165 @@
+//===-- GoToTargetsRequestHandler.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
walter-erquinigo wrote:
@santhoshe447 , the VSCode folks can take up to several weeks to reply. In the
meantime, you can check the vscode repo https://github.com/microsoft/vscode for
usages of this request to learn more about what's going on.
https://github.com/llvm/llvm-project/pull/131820
_
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/125843
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/130773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/129262
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
all good then!
https://github.com/llvm/llvm-project/pull/129919
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
I have an idea for using lldb's process list logic, although it's a bit of code.
1. Don't use `"${command:pickProcess}"` at all. We need to bypass the regular
command logic. You could use a wildcard like `${pickProcess}`.
2. In the debug config resolution logic, which is
@@ -66,19 +70,17 @@ async function findDAPExecutable(): Promise {
}
async function getDAPExecutable(
- session: vscode.DebugSession,
+ folder: vscode.WorkspaceFolder | undefined,
walter-erquinigo wrote:
call this workspaceFolder because this is not any fold
@@ -13,8 +13,8 @@
using namespace lldb_dap;
BreakpointBase::BreakpointBase(DAP &d, const llvm::json::Object &obj)
-: dap(d), condition(std::string(GetString(obj, "condition"))),
- hitCondition(std::string(GetString(obj, "hitCondition"))) {}
+: dap(d), condition(st
@@ -0,0 +1,110 @@
+//===-- MemoryMonitor.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,110 @@
+//===-- MemoryMonitor.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -517,6 +520,16 @@
"cwd": "^\"\\${workspaceRoot}\""
}
},
+ {
+"label": "LLDB: Attach to Process",
+"description": "",
+"body": {
+ "type": "lldb-dap",
+ "request": "atta
https://github.com/walter-erquinigo approved this pull request.
sorry for the late review, this LGTM
I suggested refactoring main a bit. If you can do it, it would be great, but
all good if you don't. But next time we add more stuff to main, it would be
good simplify that function a bit
https:
@@ -4952,6 +4895,29 @@ static int DuplicateFileDescriptor(int fd) {
#endif
}
+static llvm::Expected>
+validateConnection(llvm::StringRef conn) {
+ auto uri = lldb_private::URI::Parse(conn);
+
+ if (uri && (uri->scheme == "tcp" || uri->scheme == "connect" ||
+ !u
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/116392
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
Thanks!!
https://github.com/llvm/llvm-project/pull/125347
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo commented:
This LGTM, but before merging, could you share more about the differences
between the these cases and the actual logic between this patch and the
previous attempt?
https://github.com/llvm/llvm-project/pull/125347
_
@@ -140,6 +140,10 @@ Changes to LLDB
Therefore current implementation allows only 1 watchpoint, as tested with
Windows 11 on the Microsoft SQ2 and Snapdragon Elite X platforms.
+### Changes to lldb-dap
+
+* Breakpoints can now be set for specific columns within a line
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/125347
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -44,12 +44,16 @@ class ProgressEventData : public EventData {
uint64_t GetCompleted() const { return m_completed; }
uint64_t GetTotal() const { return m_total; }
std::string GetMessage() const {
-std::string message = m_title;
-if (!m_details.empty()) {
-
https://github.com/walter-erquinigo commented:
To be honest it's a bit hard to review this because I'm not versed in these low
level APIs, let along Windows. Could you make sure that your changes pass mac,
linux and windows CI? IIRC you can trigger manually buildbots if you want to
run custom
@@ -21,21 +23,22 @@ namespace lldb_dap {
/// The file is destroyed when the destructor is invoked.
struct FifoFile {
FifoFile(llvm::StringRef path);
+ FifoFile(llvm::StringRef path, FILE *f);
+ // FifoFile(llvm::StringRef path, FILE *f);
+ FifoFile(FifoFile &&other);
+
+
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/121269
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -111,8 +111,10 @@ Error
RunInTerminalLauncherCommChannel::WaitUntilDebugAdaptorAttaches(
return message.takeError();
}
-Error RunInTerminalLauncherCommChannel::NotifyPid() {
- return m_io.SendJSON(RunInTerminalMessagePid(getpid()).ToJSON());
+Error RunInTerminalLaunch
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/123826
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/120457
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
@ashgti , this looks very nice! It's good overall that we are able to reuse
some components and reduce the number of responsibilities in lldb-dap.
https://github.com/llvm/llvm-project/pull/120457
___
lldb-commits mailing list
walter-erquinigo wrote:
I imagine that your change does make sense, but it's really not strictly tied
to lldb-dap. It's more generic and it's about what happens when the expression
evaluator is invoked from SBFrame when the process is not stopped, right?
In any case, please reduce this PR to ju
walter-erquinigo wrote:
You are a good person, @JDevlieghere
https://github.com/llvm/llvm-project/pull/118894
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/118681
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -28,6 +23,70 @@ export class LLDBDapDescriptorFactory
return true;
}
+ static async findDAPExecutable(): Promise {
+let executable = "lldb-dap";
+if (process.platform === "win32") {
+ executable = "lldb-dap.exe";
+}
walter-erquinigo
1 - 100 of 1031 matches
Mail list logo
