================ @@ -116,7 +116,22 @@ void DisassembleRequestHandler::operator()( const auto inst_count = GetInteger<int64_t>(arguments, "instructionCount").value_or(0); - lldb::SBInstructionList insts = dap.target.ReadInstructions(addr, inst_count); + + std::string flavor_string{}; + const auto target_triple = llvm::StringRef(dap.target.GetTriple()); ---------------- walter-erquinigo wrote:
I can't think of a clean way to unify this with the code in source/Commands/CommandObjectDisassemble.cpp, but at the very least make a comment here and in source/Commands/CommandObjectDisassemble.cpp::OptionParsingStarting mentioning that they are duplicated logic, so that future changes are done correctly https://github.com/llvm/llvm-project/pull/134722 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits